Add basic latency benchmarks for migrations #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
approved these changes
May 25, 2021
| { passphrase: #{fixturePassphrase} | ||
| , addresses: #{addresses} | ||
| }|] | ||
| fmtResult "postMigration " t12b |
lib/shelley/bench/Latency.hs
Outdated
| @@ -203,15 +204,16 @@ walletApiBench capture ctx = do | |||
| nFixtureWallet n = do | |||
| wal1 : wal2 : _ <- replicateM n (fixtureWallet ctx) | |||
| walMA <- fixtureMultiAssetWallet ctx | |||
| pure (wal1, wal2, walMA) | |||
| walMAForMigration <- fixtureMultiAssetWallet ctx | |||
| pure (wal1, wal2, walMA, walMAForMigration) | |||
There was a problem hiding this comment.
Hi @piotr-iohk! This is just a suggestion, but perhaps we could use a name that makes it obvious that it's a source wallet to be migrated:
Suggested change
| pure (wal1, wal2, walMA, walMAForMigration) | |
| pure (wal1, wal2, walMA, maWalletToMigrate) |
What do you think about this name?
("For migration" could imply that it's a target wallet.)
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 25, 2021
2665: Add basic latency benchmarks for migrations r=piotr-iohk a=piotr-iohk # Issue Number ADP-680 # Overview - 2c31861 Add basic latency benchmarks for migrations # Comments [Migration Plan](http://cardano-wallet-benchmarks.herokuapp.com/latency?latency_category=4&latency_benchmark=all&latency_measurement=postMigrationPlan) [Migration](http://cardano-wallet-benchmarks.herokuapp.com/latency?latency_category=4&latency_benchmark=all&latency_measurement=postMigration) Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
|
Build failed: #timeout |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 25, 2021
2665: Add basic latency benchmarks for migrations r=piotr-iohk a=piotr-iohk # Issue Number ADP-680 # Overview - 2c31861 Add basic latency benchmarks for migrations # Comments [Migration Plan](http://cardano-wallet-benchmarks.herokuapp.com/latency?latency_category=4&latency_benchmark=all&latency_measurement=postMigrationPlan) [Migration](http://cardano-wallet-benchmarks.herokuapp.com/latency?latency_category=4&latency_benchmark=all&latency_measurement=postMigration) Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
|
Build failed: #timeout |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 25, 2021
2665: Add basic latency benchmarks for migrations r=piotr-iohk a=piotr-iohk # Issue Number ADP-680 # Overview - 2c31861 Add basic latency benchmarks for migrations # Comments [Migration Plan](http://cardano-wallet-benchmarks.herokuapp.com/latency?latency_category=4&latency_benchmark=all&latency_measurement=postMigrationPlan) [Migration](http://cardano-wallet-benchmarks.herokuapp.com/latency?latency_category=4&latency_benchmark=all&latency_measurement=postMigration) 2667: Add property test for `UTxOIndex.selectRandomWithPriority`. r=jonathanknowles a=jonathanknowles # Issue Number ADP-890 # Overview This PR adds a property test for `UTxOIndex.selectRandomWithPriority`. The `selectRandomWithPriority` function is designed to: - select an entry at random from a UTxO index according to a specified list of filter conditions; - traverse the specified list of filter conditions in order of priority **_from left to right_**. The test added in this PR provides a basic sanity check to verify that priority order is respected. # Sample Output ```hs Cardano.Wallet.Primitive.Types.UTxOIndex Indexed UTxO set properties Index Selection prop_selectRandomWithPriority +++ OK, passed 1600 tests: 59.69% have match for neither asset 1 nor asset 2 17.12% have match for asset 1 but not for asset 2 16.31% have match for asset 2 but not for asset 1 6.88% have match for both asset 1 and asset 2 Finished in 1.0870 seconds 1 example, 0 failures ``` # QA Due Diligence I ran this test 500 times to increase confidence that it will not fail spuriously. No failures were encountered. Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-680
Overview
Add basic latency benchmarks for migrations
Comments
Migration Plan
Migration