-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic latency benchmarks for migrations #2665
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ import Cardano.Wallet.Api.Types | |
, ApiTxId (..) | ||
, ApiUtxoStatistics | ||
, ApiWallet | ||
, ApiWalletMigrationPlan (..) | ||
, EncodeAddress (..) | ||
, WalletStyle (..) | ||
) | ||
|
@@ -203,15 +204,16 @@ walletApiBench capture ctx = do | |
nFixtureWallet n = do | ||
wal1 : wal2 : _ <- replicateM n (fixtureWallet ctx) | ||
walMA <- fixtureMultiAssetWallet ctx | ||
pure (wal1, wal2, walMA) | ||
walMAForMigration <- fixtureMultiAssetWallet ctx | ||
pure (wal1, wal2, walMA, walMAForMigration) | ||
|
||
-- Creates n fixture wallets and send 1-ada transactions to one of them | ||
-- (m times). The money is sent in batches (see batchSize below) from | ||
-- additionally created source fixture wallet. Then we wait for the money | ||
-- to be accommodated in recipient wallet. After that the source fixture | ||
-- wallet is removed. | ||
nFixtureWalletWithTxs n m = do | ||
(wal1, wal2, walMA) <- nFixtureWallet n | ||
(wal1, wal2, walMA, walMAForMigration) <- nFixtureWallet n | ||
|
||
let amt = minUTxOValue | ||
let batchSize = 10 | ||
|
@@ -226,12 +228,12 @@ walletApiBench capture ctx = do | |
let expInflows' = filter (/=0) expInflows | ||
|
||
mapM_ (repeatPostTx wal1 amt batchSize . amtExp) expInflows' | ||
pure (wal1, wal2, walMA) | ||
pure (wal1, wal2, walMA, walMAForMigration) | ||
|
||
nFixtureWalletWithUTxOs n utxoNumber = do | ||
let utxoExp = replicate utxoNumber minUTxOValue | ||
wal1 <- fixtureWalletWith @n ctx utxoExp | ||
(_, wal2, walMA) <- nFixtureWallet n | ||
(_, wal2, walMA, walMAForMigration) <- nFixtureWallet n | ||
|
||
eventually "Wallet balance is as expected" $ do | ||
rWal1 <- request @ApiWallet ctx | ||
|
@@ -247,7 +249,7 @@ walletApiBench capture ctx = do | |
(Link.getUTxOsStatistics @'Shelley wal1) Default Empty | ||
expectResponseCode HTTP.status200 rStat | ||
expectWalletUTxO (fromIntegral <$> utxoExp) (snd rStat) | ||
pure (wal1, wal2, walMA) | ||
pure (wal1, wal2, walMA, walMAForMigration) | ||
|
||
repeatPostTx wDest amtToSend batchSize amtExp = do | ||
wSrc <- fixtureWallet ctx | ||
|
@@ -283,7 +285,7 @@ walletApiBench capture ctx = do | |
expectResponseCode HTTP.status202 r | ||
return r | ||
|
||
runScenario scenario = runResourceT $ scenario >>= \(wal1, wal2, walMA) -> liftIO $ do | ||
runScenario scenario = runResourceT $ scenario >>= \(wal1, wal2, walMA, walMAForMigration) -> liftIO $ do | ||
t1 <- measureApiLogs capture | ||
(request @[ApiWallet] ctx (Link.listWallets @'Shelley) Default Empty) | ||
fmtResult "listWallets " t1 | ||
|
@@ -384,6 +386,23 @@ walletApiBench capture ctx = do | |
(Link.getAsset walMA polId assName) Default Empty | ||
fmtResult "getMultiAsset " t11 | ||
|
||
-- Create a migration plan: | ||
let endpointPlan = (Link.createMigrationPlan @'Shelley walMAForMigration) | ||
t12a <- measureApiLogs capture $ request @(ApiWalletMigrationPlan n) | ||
ctx endpointPlan Default $ | ||
Json [json|{addresses: #{addresses}}|] | ||
fmtResult "postMigrationPlan " t12a | ||
|
||
-- Perform a migration: | ||
let endpointMigrate = Link.migrateWallet @'Shelley walMAForMigration | ||
t12b <- measureApiLogs capture $ request @[ApiTransaction n] | ||
ctx endpointMigrate Default $ | ||
Json [json| | ||
{ passphrase: #{fixturePassphrase} | ||
, addresses: #{addresses} | ||
}|] | ||
fmtResult "postMigration " t12b | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏻 |
||
|
||
pure () | ||
where | ||
arbitraryStake :: Maybe Coin | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @piotr-iohk! This is just a suggestion, but perhaps we could use a name that makes it obvious that it's a source wallet to be migrated:
What do you think about this name?
("For migration" could imply that it's a target wallet.)