cabal: Add version constraint on random #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In later versions, `StdGen` no longer has a `Read` instance.
rvl
force-pushed
the
rvl/adp-961/fix-cabal-constraints
branch
2 times, most recently
from
b24a083
to
8fb8912
Compare
rvl
force-pushed
the
rvl/adp-961/fix-cabal-constraints
branch
from
8fb8912
to
75a245f
Compare
sevanspowell
approved these changes
Jun 7, 2021
sevanspowell
reviewed
Jun 7, 2021
| -- Disable all other tests. This is what they do in the cardano-node | ||
| -- cabal project. | ||
| -- The global tests: False flag doesn't seem to work though. | ||
| -- Now disable all other tests with a global flag. |
There was a problem hiding this comment.
Does this actually work? I've always had trouble with cabal.project's and global flags.
I've tried things like
package *:
tests: False
In the past but haven't had it work.
There was a problem hiding this comment.
It seems to work for me locally, and the CI builds also work (whereas before they were failing due to difficult test suite dependencies). I think key part is using Cabal 3.4.0.0.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 7, 2021
2686: cabal: Add version constraint on random r=rvl a=rvl # Issue Number ADP-961 # Overview In `random>=1.2.0`, `StdGen` no longer has a `Read` instance. - Add version constraint so Cabal uses previous version. - Clean up `cabal.project`, with the assumption of Cabal >= 3.4.0.0. - Add a nightly CI step to run the cabal build. - Use cabal-cache to make the nightly build faster. - Make sure every Haskell tool built for the nix-shell has a materialization, for faster evaluation without warnings. # Comments Resolves #2685. We may fix the usage of `instance Read StdGen` later. 2688: Restoration bench: increase heap and only bench {0%,0.2%} x {seq,rnd} r=rvl a=Anviking # Issue Number ADP-846 # Overview Let the nightly benchmark finish successfully within the alotted time. - [x] Increase max heap from 8GB to 16GB - [x] Replace 0.1% and 0.4% rnd and seq benchmarks with 0.2% to prevent timeout. # Comments [](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=anviking%2FADP-846%2Fmore-heap) Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=anviking%2FADP-846%2Fmore-heap){kind=link}
|
Build failed (retrying...): #2467, but the third one looks like something different... |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-961
Overview
In
random>=1.2.0,StdGenno longer has aReadinstance.cabal.project, with the assumption of Cabal >= 3.4.0.0.Comments
Resolves #2685.
We may fix the usage of
instance Read StdGenlater.