Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light mode: Tx includes non-native assets #3424

Merged
merged 2 commits into from Aug 9, 2022
Merged

Light mode: Tx includes non-native assets #3424

merged 2 commits into from Aug 9, 2022

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Aug 5, 2022

Originally, light-mode implementation supported only ADA coins, ignoring all non-ADA assets.

This PR adds a support for the non-ADA assets.

Issue Number

ADP-1777

@Unisay
Copy link
Contributor Author

Unisay commented Aug 5, 2022

bors try

iohk-bors bot added a commit that referenced this pull request Aug 5, 2022
@iohk-bors
Try #3424:
489cd9a
@Unisay Unisay self-assigned this Aug 5, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 5, 2022 •
edited by Unisay

try

Build failed:

       Waited longer than 300s to resolve action: "metadata is fetched".
       expected: [PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}]
        but got: []

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools/"

Randomized with seed 1465988417

@Unisay
Copy link
Contributor Author

Unisay commented Aug 8, 2022

bors try

iohk-bors bot added a commit that referenced this pull request Aug 8, 2022
@iohk-bors
Try #3424:
7a0a70a
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 8, 2022 •
edited by Unisay

try

Build failed:

       Waited longer than 300s to resolve action: "metadata is fetched".
       expected: [PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}]
        but got: []

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools/"

Randomized with seed 766248761

@Unisay
Copy link
Contributor Author

Unisay commented Aug 8, 2022

bors try

iohk-bors bot added a commit that referenced this pull request Aug 8, 2022
@iohk-bors
Try #3424:
9eca2fb
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 8, 2022 •
edited by Unisay

try

Build failed:

       Waited longer than 300s to resolve action: "metadata is fetched".
       expected: 3
        but got: 4

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools/"

Randomized with seed 1437494834

@Unisay Unisay force-pushed the yura/ADP-1777/non-native-assets branch from 7d8c6c9 to cba1b13 Compare August 9, 2022 08:19
HeinrichApfelmus
HeinrichApfelmus approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 😊 I would add a comment about the reasoning behind the number 56, though, see suggestion.

lib/shelley/src/Cardano/Wallet/Shelley/Network/Blockfrost.hs Outdated Show resolved Hide resolved
@Unisay @HeinrichApfelmus
Update lib/shelley/src/Cardano/Wallet/Shelley/Network/Blockfrost.hs
f816524 
Co-authored-by: Heinrich Apfelmus <heinrich.apfelmus@iohk.io>
@Unisay
Copy link
Contributor Author

Unisay commented Aug 9, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 9, 2022
@iohk-bors @Unisay
Merge #3424
b368882 
3424: Light mode: Tx includes non-native assets r=Unisay a=Unisay

Originally, light-mode implementation supported only ADA coins, ignoring all non-ADA assets. 

This PR adds a support for the non-ADA assets.

### Issue Number

ADP-1777


Co-authored-by: Yuriy Lazaryev <yuriy.lazaryev@iohk.io>
Co-authored-by: Yura Lazarev <Unisay@users.noreply.github.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 9, 2022 •
edited by Anviking

Build failed:

       Waited longer than 90s to resolve action: "Wallet has consumed rewards".
       expected: Quantity 0
        but got: Quantity 2097463

  To rerun use: --match "/API Specifications/NEW_SHELLEY_TRANSACTIONS/TRANS_NEW_JOIN_01a - Can join stakepool, rejoin another and quit/"

Randomized with seed 603097212

#2467

@Unisay
Copy link
Contributor Author

Unisay commented Aug 9, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 9, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 34c1da5 into master Aug 9, 2022
@iohk-bors iohk-bors bot deleted the yura/ADP-1777/non-native-assets branch August 9, 2022 16:30
WilliamKingNoel-Bot pushed a commit that referenced this pull request Aug 9, 2022
docs: Merge #3424
4bd97f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@Unisay Unisay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Unisay @HeinrichApfelmus