Sqlite benchmark: Use a file-based DB #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jun 4, 2019
| , fmt | ||
| , memory | ||
| , temporary |
There was a problem hiding this comment.
Note that there's no need for an extra dependency here, we already have what we need from the base package:
https://hackage.haskell.org/package/base-4.11.1.0/docs/System-IO.html#v:openTempFile
Or am I missing something 🤔 ?
There was a problem hiding this comment.
openTempFile needs to be given a directory for the file. It's usually /tmp on Linux, but there are environment variables that control it. On Windows and MacOS, who knows what it might be. And we are going to want to run our database tests on these platforms.
withSystemTempFile and friends find the system temp directory for you.
KtorZ
force-pushed
the
rvl/154/db-bench
branch
2 times, most recently
from
97c88df
to
34c23eb
Compare
rvl
force-pushed
the
rvl/154/bench-db-file
branch
from
fb51d53
to
01aad4d
Compare
paweljakubas
approved these changes
Jun 5, 2019
KtorZ
approved these changes
Jun 5, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #154
Comments
Using the SQLite in-memory database might not be realistic enough. For example, I noticed a big difference between file and memory DBs for the SeqState benchmark.
So just use a file database in
/tmp/bench12345-1.db.