Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small fixes to DB.StateMachine module. #349

Merged
merged 9 commits into from
Jun 4, 2019
Merged

Some small fixes to DB.StateMachine module. #349

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da73f8b
Use plural name for map of private keys within `Mock` data type.
jonathanknowles Jun 4, 2019
34a4965
Avoid repetition by moving application of `fmap At`.
jonathanknowles Jun 4, 2019
8beb8a4
Use standard indentation (4 spaces).
jonathanknowles Jun 4, 2019
48afdb5
Wrap code to standard 80 characters.
jonathanknowles Jun 4, 2019
48131de
Fix bug where the incorrect tag was returned from `createThreeWallets`.
jonathanknowles Jun 4, 2019
071c320
Inline arguments to function `readAfterDelete`.
jonathanknowles Jun 4, 2019
5c84d1e
Add missing space.
jonathanknowles Jun 4, 2019
901edf5
Fix typo and add full stops to Haddock comments.
jonathanknowles Jun 4, 2019
8048d37
Delete obsolete comment.
jonathanknowles Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/core/test/unit/Cardano/Wallet/DB/StateMachine.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ lockstep m@(Model _ ws) c (At resp) = Event
Generator
-------------------------------------------------------------------------------}

-- NOTE 'concat' reads better.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this comment wasn't obsolete. It gives a justification for disabling hlint below. Hlint suggests to replace use of concat with ++, but concat reads better :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jonathanknowles ^^

{-# ANN generator ("HLint: ignore Use ++" :: String) #-}
generator :: Model Symbolic -> Maybe (Gen (Cmd :@ Symbolic))
generator (Model _ wids) = Just $ frequency $ fmap (fmap At) <$> concat
Expand Down