Sqlite: Fix deletion for larger numbers of checkpoints/transactions #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would have exploded if there were more than 999 TxMeta or PendingTx. I tried Esqueleto and it can't do this query. Actually, it could express the query, but the generated SQL was invalid. And the code looked just as bad as raw SQL.
KtorZ
approved these changes
Jun 4, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #154.
Base branch is #341 , so that needs to be merged first.
Overview
Any instance of
deleteWhereand<-.together is potentially a place where there will be too many variables in the SQL statement.This removes those instances and replaces them with batched deletes (
deleteMany), or where that's not possible, a delete from a join.Comments