Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite: Fix deletion for larger numbers of checkpoints/transactions #360

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Sqlite: Fix deletion for larger numbers of checkpoints/transactions #360

merged 2 commits into from
Jun 4, 2019

Commits on Jun 4, 2019

  1. Sqlite: use deleteMany where deleting checkpoints

    @rvl
    rvl committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    d8a6315 View commit details
    Browse the repository at this point in the history

  2. Sqlite: Use a join for deleteLooseTransactions 

    It would have exploded if there were more than 999 TxMeta or
PendingTx.

I tried Esqueleto and it can't do this query. Actually, it could
express the query, but the generated SQL was invalid. And the code
looked just as bad as raw SQL.
    @rvl
    rvl committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    6c12473 View commit details
    Browse the repository at this point in the history