Use SQLite in restoration benchmark (instead of MVar implementation) #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Splitting the address state tables into a separate Persistent TH module is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#154
Overview
Comments
As expected, this is slightly slower (for testnet at least), but, memory now remains within acceptable bounds instead of growing towards infinity. Below, comparison of the heap profile between the MVar (in first) and the SQLite (in second):. Curious to see what it looks like on Mainnet :)
FIGURE 1: restoration benchmark - testnet - MVar
FIGURE 2: restoration benchmark - testnet - SQLite