Merge 'cardano-wallet-launcher' & 'cardano-wallet' together #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
commented
Jun 14, 2019
| --state <STRING> address state: either used or unused | ||
| --state-dir <DIR> write wallet state (blockchain and database) to this directory |
There was a problem hiding this comment.
I've sorted all the options alphabetically.
KtorZ
commented
Jun 14, 2019
| out `shouldContain` "cardano-wallet-launcher" | ||
| c `shouldBe` ExitSuccess | ||
| forM_ ["-h", "--help"] test | ||
|
|
There was a problem hiding this comment.
The same tests already exist for cardano-wallet
piotr-iohk
reviewed
Jun 14, 2019
Anviking
reviewed
Jun 14, 2019
KtorZ
force-pushed
the
KtorZ/368/merge-cardano-launcher
branch
from
ff4368e
to
94623f8
Compare
1 task
KtorZ
force-pushed
the
KtorZ/368/merge-cardano-launcher
branch
from
94623f8
to
840fa20
Compare
Anviking
approved these changes
Jun 14, 2019
This was referenced Jun 14, 2019
KtorZ
force-pushed
the
KtorZ/368/merge-cardano-launcher
branch
3 times, most recently
from
3af8dba
to
14589c9
Compare
There's a non-significant cost with the use of 'fixtureWallet' since it needs to restore a funded wallet and wait until restoration. We also only have a limited number of those wallets, so it's better to keep them for when we actually really need funded wallets. When testing parsing errors or wrong headers, there's no need for demanding a wallet with funds
And right now, it's making the test fail because we do need a funded wallet to make this test. So it'll be best to re-introduce it as part of a separate scenario, that we only run for the bridge
This takes the cardano-sl/cardano-shell NodeIPC code and splits the general nodejs child_process IPC protocol out from the Daedalus/Cardano specific protocol, improves the exception handling, changes the logging, and just makes it simpler.
Removing a type constructor can change the shape of the JSON.
KtorZ
force-pushed
the
KtorZ/368/merge-cardano-launcher
branch
from
14589c9
to
725c822
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#368
Overview
cardano-wallet-launcherused to do.cardano-wallet launchcardano-wallet servertocardano-wallet serveas discussed briefly on slack--portand--random-portoptions for thelaunchcommandComments