reduce usage of 'fixtureWallet' in the integration tests #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a non-significant cost with the use of 'fixtureWallet' since it needs to restore a funded wallet and wait until restoration. We also only have a limited number of those wallets, so it's better to keep them for when we actually really need funded wallets. When testing parsing errors or wrong headers, there's no need for demanding a wallet with funds
KtorZ
force-pushed
the
KtorZ/remove-unnecessary-fixtureWallet-usage
branch
from
a3ee634
to
8d11050
Compare
|
Merging into #414 to group PRs and avoid multiple merges because of CI issues due to stack major bump today .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
fixtureWalletcalls withemptyWalletwhere a funded wallet wasn't necessary.Comments
There's a non-significant cost with the use of 'fixtureWallet' since it needs to restore a funded wallet
and wait until restoration. We also only have a limited number of those wallets, so it's better to keep
them for when we actually really need funded wallets. When testing parsing errors or wrong headers, there's no need for demanding a wallet with funds