Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3258] Enable integration tests in Conway era #4410

Merged
merged 5 commits into from
Jan 30, 2024
Merged

[ADP-3258] Enable integration tests in Conway era #4410

merged 5 commits into from
Jan 30, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jan 25, 2024 •
edited
Loading

  • Enable all integration tests in Conway
  • Mark tests that are failing for Conway WIP as pending (grep for noConway)
  • Set AsyncExceptions logging to critical
  • Bump NodeToClient protocol version to from V_13 to V_16

ADP-3258

@paolino paolino changed the base branch from master to HeinrichApfelmus/ADP-3266/fix-wallet January 25, 2024 16:49
@paolino paolino self-assigned this Jan 25, 2024
@paolino paolino force-pushed the HeinrichApfelmus/ADP-3266/fix-wallet branch from 8a2c5cf to 787c737 Compare January 26, 2024 14:59
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch from 84004c8 to 6d584af Compare January 26, 2024 15:07
@paolino paolino force-pushed the HeinrichApfelmus/ADP-3266/fix-wallet branch from 389c28c to e215888 Compare January 26, 2024 15:17
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch 3 times, most recently from fee4951 to 13d889c Compare January 26, 2024 15:43
@paolino paolino force-pushed the HeinrichApfelmus/ADP-3266/fix-wallet branch from e215888 to 0c1b972 Compare January 26, 2024 15:49
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch from 13d889c to 3922765 Compare January 26, 2024 15:49
Base automatically changed from HeinrichApfelmus/ADP-3266/fix-wallet to HeinrichApfelmus/ADP-3266/ghc-9.6.3 January 26, 2024 16:10
@paolino paolino force-pushed the HeinrichApfelmus/ADP-3266/ghc-9.6.3 branch from 4d69ef2 to e7d1167 Compare January 26, 2024 16:14
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch 2 times, most recently from 23c3cae to 7727285 Compare January 26, 2024 17:35
Base automatically changed from HeinrichApfelmus/ADP-3266/ghc-9.6.3 to master January 29, 2024 09:19
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch 3 times, most recently from 04d79e6 to c49bd41 Compare January 29, 2024 13:31
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch 4 times, most recently from be625c7 to c05d64e Compare January 29, 2024 16:02
@paolino paolino added the Conway PRs to prepare to the Conway bump label Jan 29, 2024
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch from c05d64e to ec73181 Compare January 29, 2024 16:12
@paolino paolino marked this pull request as ready for review January 29, 2024 16:14
@paolino paolino force-pushed the paolino/ADP-3258/enable-integration-tests-in-conway branch from ec73181 to 61c6037 Compare January 29, 2024 16:25
HeinrichApfelmus
HeinrichApfelmus approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

Ideally, we would like to use the local-cluster executable for our integration tests at some point, but perhaps not in this pull request.

@paolino paolino added this pull request to the merge queue Jan 30, 2024
@paolino
Copy link
Collaborator Author

paolino commented Jan 30, 2024 •
edited
Loading

Yes, switching to local-cluster executable is something useful but orthogonal to the Conway rush

Merged via the queue into master with commit 8738867 Jan 30, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3258/enable-integration-tests-in-conway branch January 30, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Conway PRs to prepare to the Conway bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paolino @HeinrichApfelmus