[ADP-3212] DB migration of delegation store to support voting state #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
force-pushed
the
paolino/ADP-3212/delegation-db-migration
branch
2 times, most recently
from
c4b3770
to
9ba8744
Compare
HeinrichApfelmus
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thanks! 😊 A couple of suggestions.
One suggestion up for debate: I think it makes sense to rename "active" to "delegating" in order to better disambiguate it from the new "voting" status. 🤔 This would require a migration of the values in the existing table, but with the new migration scheme, I think that we can afford that.
lib/wallet/src/Cardano/Wallet/DB/Store/Delegations/Migrations/Conway/Migration.hs
Outdated
Show resolved
Hide resolved
lib/wallet/src/Cardano/Wallet/DB/Store/Delegations/Migrations/Lean/Migration.hs
Outdated
Show resolved
Hide resolved
paweljakubas
force-pushed
the
paweljakubas/ADP-3212/voting-primitives
branch
from
5f1bc71
to
b3fc551
Compare
Base automatically changed from
paweljakubas/ADP-3212/voting-primitives
to
master
February 5, 2024 16:51
paolino
force-pushed
the
paolino/ADP-3212/delegation-db-migration
branch
2 times, most recently
from
105430b
to
02a631e
Compare
paolino
force-pushed
the
paolino/ADP-3212/delegation-db-migration
branch
from
02a631e
to
92b1cc1
Compare
paolino
force-pushed
the
paolino/ADP-3212/delegation-db-migration
branch
from
92b1cc1
to
dcca782
Compare
…e migration result
paolino
force-pushed
the
paolino/ADP-3212/delegation-db-migration
branch
from
2f84117
to
fe3af5f
Compare
HeinrichApfelmus
approved these changes
Feb 6, 2024
lib/wallet/test/unit/Cardano/Wallet/DB/Store/Delegations/Migrations/V5Spec.hs
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- V2: only contain the historical schema
- V3: contains the migration from V2 to V3 schema and the V3 schema itself (Lean introduction)
- V5: contains the migration from V3 to V5 (Conway changes)
- V5 schema takes place of V3 schema at top level
ADP-3212