-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3305] Add send faucet end-point to local cluster #4566
[ADP-3305] Add send faucet end-point to local cluster #4566
Conversation
658ccbf
to
70ee798
Compare
dd8c4d2
to
5738324
Compare
c6044e3
to
6b163b4
Compare
31c3d71
to
ed57c88
Compare
0380a12
to
e323174
Compare
ed57c88
to
92d722a
Compare
e323174
to
33aa815
Compare
92d722a
to
bce55b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 😊
The code itself looks good to me, but I feel that the separation of concerns is confused. 🤔 I would have expected that the HTTP API for the local cluster sits under
Cardano.Wallet.Launch.Cluster.Http.*
and that the monitoring part is grouped under
Cardano.Wallet.Launch.Cluster.Http.Monitoring.*
while the faucet part is grouped under
Cardano.Wallet.Launch.Cluster.Http.Faucet.*
or ``Cardano.Wallet.Launch.Cluster.Http.Application.*`
It's true that the local cluster is a group of nodes that are running, but at the same time, I think it's also fair to say that "this group has an HTTP interface" (this interface happens to be served by the local-cluster
executable) as opposed to "this group can be monitored by an additional process, and the monitor to has an HTTP interface". I think it's conceptually simpler to attribute the HTTP interface to "the cluster".
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Http/ApiT.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Http/Application/Server.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Http/Client.hs
Outdated
Show resolved
Hide resolved
{-# LANGUAGE UndecidableInstances #-} | ||
{-# OPTIONS_GHC -Wno-orphans #-} | ||
|
||
module Cardano.Wallet.Launch.Cluster.Monitoring.Http.Control.API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module Cardano.Wallet.Launch.Cluster.Monitoring.Http.Control.API | |
module Cardano.Wallet.Launch.Cluster.Http.Monitoring.API |
? 🤔
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Http/Control/Client.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Http/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Http/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Monitoring/Monitor.hs
Outdated
Show resolved
Hide resolved
f2a96ba
to
0c27826
Compare
0c27826
to
6329afc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you! 😊
A couple of suggestion to make the use of AssetMetadata
more consistent, but otherwise, good to go.
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Http/Faucet/SendFaucetAssets.hs
Outdated
Show resolved
Hide resolved
6329afc
to
adf56ab
Compare
16aceef
to
65c1da1
Compare
ADP-3305