[ADP-3359] Report unaccepted-era transactions as HTTP 403 errors #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
requested changes
May 16, 2024
There was a problem hiding this comment.
When adding UnsupportedEraInTxSubmission you need to add its counterparts in swagger, so something like :
x-errUnsupportedEraInTxSubmission: &errUnsupportedEraInTxSubmission
<<: *responsesErr
title: unsupported_era_in_tx_submission
properties: message:
type: string
description: |
Happens when transaction was constructed before Babbage era
code:
type: string
enum: ['unsupported_era_in_tx_submission']
And insert errUnsupportedEraInTxSubmission under proper submit endpoint in 403 hierarchy.
Without it unit test will fail as there is no correspondence between ApiError and swagger errors.
Also, what about adding integration test with Alonzo tx as a cbor and showing that the endpoint endup with 403 and proper error msg?
paolino
force-pushed
the
paolino/ADP-3359/report-unacceptet-era-tx-as-403
branch
5 times, most recently
from
2d69876
to
638da7f
Compare
paolino
force-pushed
the
paolino/ADP-3359/report-unacceptet-era-tx-as-403
branch
from
638da7f
to
345f905
Compare
There was a problem hiding this comment.
Hi @paolino
Many thanks for making this PR.
I've left some suggestions (and one small request)!
paolino
force-pushed
the
paolino/ADP-3359/report-unacceptet-era-tx-as-403
branch
from
345f905
to
bf3471a
Compare
paweljakubas
approved these changes
May 22, 2024
jonathanknowles
deleted the
paolino/ADP-3359/report-unacceptet-era-tx-as-403
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
May 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
…s. (#4603) This PR: - adds a new constant `recentEras :: Set AnyRecentEra` - this constant defines the complete set of **_recent eras_** that are supported for transaction construction. - uses this constant to simplify the construction of the following API errors: - `ApiErrorNodeNotYetInRecentEra` - `ApiErrorUnsupportedEra` ## Issue ADP-3359 Follow-on from #4595.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2024
…e. (#4605) This PR moves the `ApiEra` type and related functions to a separate module `Api.Types.Era`. As a result: - the `ApiEra` type is co-located only with its related functions; - the `Api.Types` [megamodule](https://www.parsonsmatt.org/2019/11/27/keeping_compilation_fast.html) is now ever-so-slightly smaller. Additionally: - functions relating to `ApiEra` are now imported via the `ApiEra` qualifier; - the `Api.Types` module does **_not_** re-export symbols from `Api.Types.Era`. ## Issue ADP-3359 Follow-on from #4595.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorcall when not-in-a-recent-era tx is postedADP-3359