Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3368] Bump to support node version 8.9.3 #4617

Merged
merged 4 commits into from
Jun 5, 2024
Merged

[ADP-3368] Bump to support node version 8.9.3 #4617

merged 4 commits into from
Jun 5, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 4, 2024 •
edited
Loading

  • Bump node runtime deps to 8.9.3
  • Bump wallet compile-time deps to match the new node ones (ouroboros-network ^>= 0.15)

ADP-3368

@paolino paolino added the Conway PRs to prepare to the Conway bump label Jun 4, 2024
@paolino paolino changed the title Paolino/adp 3368/bump node version to 8.9.3 [ADP-3368] Bump to support node version 8.9.3 Jun 4, 2024
Base automatically changed from paolino/ADP-3366/add-era-dependency-to-node-config-experimental-features-param to master June 4, 2024 18:09
@paolino paolino force-pushed the paolino/ADP-3368/bump-node-version-to-8.9.3 branch from 41e711d to da70718 Compare June 5, 2024 09:25
@paolino paolino force-pushed the paolino/ADP-3368/bump-node-version-to-8.9.3 branch 6 times, most recently from 31a6ce2 to c88dc37 Compare June 5, 2024 10:20
@paolino paolino force-pushed the paolino/ADP-3368/bump-node-version-to-8.9.3 branch from c88dc37 to f1bd1b3 Compare June 5, 2024 11:15
@paolino paolino self-assigned this Jun 5, 2024
@paolino paolino marked this pull request as ready for review June 5, 2024 12:24
Anviking
Anviking reviewed Jun 5, 2024
View reviewed changes
cabal.project Show resolved Hide resolved
Anviking
Anviking approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@Anviking Anviking left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

cabal.project Show resolved Hide resolved
cabal.project Show resolved Hide resolved
@paolino paolino added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit e568d96 Jun 5, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3368/bump-node-version-to-8.9.3 branch June 5, 2024 14:34
@Anviking Anviking mentioned this pull request Jun 5, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
@Anviking
Label Plutus Context errors exhaustively in balanceTx property (#4618)
13a7b3b 
- [x] Exhaustively pattern match and label Plutus context errors such
that we don't fail if we hit the `_` "other error" case.

To fix balanceTx property
[flakiness](https://buildkite.com/cardano-foundation/cardano-wallet/builds/5219#018fe7ea-3ff1-4ad1-9a1a-cc8ca1e923cc/6-3590)
observed in #4617

### Issue Number

ADP-3368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

@HeinrichApfelmus HeinrichApfelmus Awaiting requested review from HeinrichApfelmus

Assignees

@paolino paolino

Labels
Conway PRs to prepare to the Conway bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolino @Anviking @HeinrichApfelmus