Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Jörmungandr witness calculation #464

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix Jörmungandr witness calculation #464

merged 1 commit into from
Jun 25, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jun 25, 2019 •
edited by paweljakubas
Loading

Issue Number

Overview

  • I have used the current tx id for each witness instead of the id of the corresponding inputs
  • I have re-generated golden tests and updated the doc script

Comments

And integration tests seems indeed to go one step further on @paweljakubas 's branch now, we do need to resolve the coin selection issue though.

@KtorZ KtorZ self-assigned this Jun 25, 2019
paweljakubas
paweljakubas approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tx witness calculation should be ok with this fix

@KtorZ KtorZ merged commit 6950dca into master Jun 25, 2019
@KtorZ KtorZ deleted the KtorZ/jormungandr-fix-witness branch June 25, 2019 08:27
@KtorZ KtorZ mentioned this pull request Jun 25, 2019
Merged
4 tasks
@KtorZ KtorZ added this to the Jörmungandr Integration Testing milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@Anviking Anviking Awaiting requested review from Anviking

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
Jörmungandr Integration Testing
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KtorZ @paweljakubas