Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3382] Bump to node 8.9.4 #4659

Merged
merged 2 commits into from
Jul 2, 2024
Merged

[ADP-3382] Bump to node 8.9.4 #4659

merged 2 commits into from
Jul 2, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 2, 2024 •
edited
Loading

  • Bump runtime node dependency to 8.9.4

ADP-3382

@paolino paolino self-assigned this Jul 2, 2024
@paolino paolino marked this pull request as ready for review July 2, 2024 15:25
HeinrichApfelmus
HeinrichApfelmus approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊 There are appear to be 4 additional files that should not be in here, though. 🤔

scripts/buildkite/release/docker-smoke-test.sh Outdated Show resolved Hide resolved
scripts/buildkite/release/docker-e2e.sh Outdated Show resolved Hide resolved
docker-compose-mainnet.yml Outdated Show resolved Hide resolved
docker-compose-preprod.yml Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3382/bump-to-node-8.9.4 branch from 70c1660 to 008e2b5 Compare July 2, 2024 15:54
@paolino paolino enabled auto-merge July 2, 2024 15:55
@paolino paolino added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit f9430c5 Jul 2, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3382/bump-to-node-8.9.4 branch July 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paolino @HeinrichApfelmus