Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review style of ChainProducer modules + add license header #57

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Mar 13, 2019

Issue Number

#12

Overview

  • I have adjusted a few module to be more compliant with our coding standards
  • I have removed unecessary SlottingOrphans module in order to keep spec file self-contained. Ideally, and will do that in another PR, we want to move the slotting stuff to within the wallet primitives there's no need for a separate module here.
  • I have added some license headers to files when it was missing, we haven't quite set any coding standard on that, so that is subject to debate, but it gives nice doc and, ideally, come with a description of what the module does.

Comments

@KtorZ KtorZ self-assigned this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants