Replace usage of 'mtl' with 'transformers' #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
approved these changes
Mar 18, 2019
👍 |
|
it is good to choose one (the same for the lens), the slimmest one but good enough to service our needs. Started using only |
paweljakubas
approved these changes
Mar 19, 2019
There's no strong feeling about using one or another. Transformers is slightly simpler as it doesn't introduce any of the type-classes and functional dependencies that 'mtl' adds. Though, we only use the power of 'transformers' so far, and thus, for consistency at least, let's stick with this one and only pull 'mtl' if we feel it becomes a need
KtorZ
force-pushed
the
KtorZ/mtl-vs-transformers
branch
from
c7813bb
to
8be546a
Compare
|
Although how would you change this? (from #83) https://github.com/input-output-hk/cardano-wallet/blob/9bcbc098f1f64e66ba26f29663c2f493e3eeab08/test/integration/Test/Integration/Framework/Request.hs#L75-L87 |
|
You would just remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Comments
There's no strong feeling about using one or another. I noticed we were using
ExceptTfrommtlbutStateTfromtransformersin various places in the code. So for consistency, I've opted for using the building blocks fromtransformers.mtlis built on top oftransformersanyway now, but we do not use any of the classy stuff frommtlat the moment (and there's no clear reason we will in the near future?).