Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port integration tests Request module from old codebase #83

Merged
merged 4 commits into from
Mar 21, 2019
Merged

Port integration tests Request module from old codebase #83

merged 4 commits into from
Mar 21, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 19, 2019 •
edited
Loading

Relates to #56.

Overview

This provides unsafeRequest, now called request. A little bit of the DSL module and the Scenario module were ported so that I could test the function.

@rvl rvl added this to the Wallet Layer Integration milestone Mar 19, 2019
@rvl rvl self-assigned this Mar 19, 2019
@piotr-iohk piotr-iohk mentioned this pull request Mar 19, 2019
Closed
@Anviking Anviking mentioned this pull request Mar 19, 2019
Merged
1 task
@Anviking
Copy link
Collaborator

Anviking commented Mar 19, 2019 •
edited
Loading

I pushed a commit replacing mtl with transformers (see #81).

Also I think this is basically enough for #55 too. But I would add 3cbf665.

@Anviking Anviking mentioned this pull request Mar 19, 2019
Closed
2 tasks
@rvl rvl force-pushed the rvl/56/test-request branch 3 times, most recently from debcd84 to 2dacf8f Compare March 20, 2019 05:47
@rvl
Copy link
Contributor Author

rvl commented Mar 20, 2019

@Anviking thanks. I pulled in 3cbf665 but removed the mtl/transformers change because it doesn't build. The test framework is using some mtl classes and I see nothing wrong with it.

I have rebased on master, renamed unsafeRequest to request, and added request_ and successfulRequest.

Anviking
Anviking reviewed Mar 20, 2019
View reviewed changes
test/integration/Main.hs Outdated Show resolved Hide resolved
@Anviking Anviking self-requested a review March 20, 2019 14:28
Anviking
Anviking approved these changes Mar 20, 2019
View reviewed changes
Copy link
Collaborator

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

The test framework is using some mtl classes and I see nothing wrong with it.

👍

test/integration/Main.hs Show resolved Hide resolved
test/integration/Main.hs Outdated Show resolved Hide resolved
@rvl
Copy link
Contributor Author

rvl commented Mar 20, 2019

Thanks @Anviking

rvl and others added 4 commits March 21, 2019 09:18
@rvl
Port integration tests Request module from old codebase
bb8760c 
This provides `unsafeRequest`, renamed to `request`, plus some
variations.

A little bit of the DSL module and the Scenario module was ported so
that I could test the function.

Relates to #55 and #56
@Anviking @rvl
Add and export (</>), (!!), json to DSL
73531f2
@rvl
Weeder
056c51d
@Anviking @rvl
cardano-wallet-server no longer takes a mnemonic
d5b6a44
@rvl rvl merged commit 1ae8983 into master Mar 21, 2019
@rvl rvl deleted the rvl/56/test-request branch March 21, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

@KtorZ KtorZ Awaiting requested review from KtorZ

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
Wallet Layer Integration
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvl @Anviking