Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HydraBuildList to provide latest release binaries (with fallback) #300

Merged
merged 4 commits into from
Sep 21, 2021

Conversation

tweakch
Copy link
Collaborator

@tweakch tweakch commented Sep 15, 2021

Updating documentation

Issue

Fixes #299

Description of the change

I updated the links adding the latest-finished route to always use the latest pre-built binary (as stated in the NOTE)

These links resolve to the following build ids

  • Linux: https://hydra.iohk.io/build/7630428
  • MacOS: https://hydra.iohk.io/build/7630460
  • Windows: https://hydra.iohk.io/build/7630442

Not sure if we should use them instead and lock the versions advertised in the admonition to v1.29...

I'll update the links accordingly if you guys think the build ids are a better solution.

@tweakch
Copy link
Collaborator Author

tweakch commented Sep 15, 2021

I just saw #267 which is indirectly related. I'll keep an eye out and open new issues when I find these mary / alonzo related things.

@rdlrt
Copy link
Collaborator

rdlrt commented Sep 15, 2021

Unfortunately using latest-finished is not recommended as any PR/commit on node repo will create a new hydra build - which means it will not necessarily be compatible with mainnet/or include untested changes.

If we have to automate using release builds , the specific build number can be extracted from notes in release page (example below) :

curl -s https://api.github.com/repos/input-output-hk/cardano-node/releases/latest | jq .body | sed -e 's/.*Hydra binaries](\(.*\)#tabs-constituents.*/\1#tabs-constituents/'

In terms of documenting, I suppose we can either link them to cardano-node releases page to read release notes and use links from the description OR add a custom JS (equivalent to above) to dynamically build URL on client browser OR provide them bash instructions for command as above to fetch the correct build URLs?

@tweakch
Copy link
Collaborator Author

tweakch commented Sep 17, 2021

...not necessarily be compatible with mainnet/or include untested changes.

Of course... i always forget the mainnet policy.

curl -s https://api.github.com/repos/input-output-hk/cardano-node/releases/latest | jq .body | sed -e 's/.*Hydra binaries](\(.*\)#tabs-constituents.*/\1#tabs-constituents/'

Nice.

I think I'll add a dynamic link js. I think i can get it to work thanks to your stream editor expression

@tweakch tweakch changed the title Use latest-finished to provide latests pre-built binaries Use HydraBuildList to provide latest release binaries (with fallback) Sep 19, 2021
Copy link
Collaborator Author

@tweakch tweakch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about that?

HydraBuildList renders the links to the configured binaries and displays a link to the latest release if the latest prop does not match the latest relase build id from github...

CORS header AllowOrigin * is not configured on hydra preventing me from making a second request and extract the latest buildId on the client... That's something the server needs to do but that is too much IMO...

It's my first React component so please suggest improvements... i'll be happy to add them

docs/get-started/installing-cardano-node.md Outdated Show resolved Hide resolved
src/components/docs/HydraBuildList/index.js Show resolved Hide resolved
@tweakch
Copy link
Collaborator Author

tweakch commented Sep 20, 2021

The current release build is 7408469 with build ids 7408438, 7408630 and 7408538 for linux, macos and win64 respectively.

Setting these Ids on HydraBuildList

:::note
<!-- omitted for brevity -->

<HydraBuildList
    latest="7408469"
    linux="7408438"
    macos="7408630"
    win64="7408538"/>

<!-- omitted for brevity -->
:::

Results in the following output:

image

If there is a new release of the binaries the latest buildId will change: (f.e. to 7500000)

HydraBuildList will now render the following ouput:

image

Giving us the chance to lookup the build ids of the cardano-node (f.e. 7500001,7500002,7500003) and update the component so the message about the new release will disappear again.

:::note
<!-- omitted for brevity -->

<HydraBuildList
    latest="7500000"
    linux="7500001"
    macos="7500002"
    win64="7500003"/>

<!-- omitted for brevity -->
:::

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome solution for this. (in the past we tried to put all versions into variables.js but we never manged to connect all the variables)

Copy link
Collaborator

@gufmar gufmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rdlrt rdlrt merged commit 6e0752c into cardano-foundation:staging Sep 21, 2021
katomm added a commit that referenced this pull request Sep 24, 2021
* Add smart-contract search entry point (#287)

* Add playgrounds (#288)

* Bump axios from 0.21.1 to 0.21.4 (#285)

Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes Cardano Explorer and Pull Request Template links (#272)

* changes the default language of a link's site to English

* fixes link to pull request template in contributing document

Co-authored-by: Tommy

* Adding alonzo genesis files (#291)

* Adding alonzo genesis files

* Update running-cardano.md

* fix typo (#305)

* fix typo

* september spotlight interview

Co-authored-by: Kevin Cislak 

* Removing the random constraint for building wallet (#297)

Building the wallet with `--constraint="random<1.2"` results in:

```
Building library for cardano-wallet-core-2021.9.9..
[59 of 95] Compiling Cardano.Wallet.DB.Sqlite.Types ( src/Cardano/Wallet/DB/Sqlite/Types.hs, /home/cardano/cardano-src/cardano-wallet/dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-wallet-core-2021.9.9/build/Cardano/Wallet/DB/Sqlite/Types.o, /home/cardano/cardano-src/cardano-wallet/dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-wallet-core-2021.9.9/build/Cardano/Wallet/DB/Sqlite/Types.dyn_o )

src/Cardano/Wallet/DB/Sqlite/Types.hs:122:1: error:
    Could not load module ‘System.Random.Internal’
    It is a member of the hidden package ‘random-1.2.0’.
    Perhaps you need to add ‘random’ to the build-depends in your .cabal file.
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
    |
122 | import System.Random.Internal
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...
cabal: Failed to build cardano-wallet-core-2021.9.9 (which is required by
exe:local-cluster from cardano-wallet-2021.9.9, test:integration from
cardano-wallet-2021.9.9 and others).
```

Issue here: cardano-foundation/cardano-wallet#2824
Raising this PR to discuss as I don't understand the significance of removing the constraint.

Versions:
* cardano-wallet tag v2021-09-09
* cabal-install version 3.4.0.0
* compiled using version 3.4.0.0 of the Cabal library
* The Glorious Glasgow Haskell Compilation System, version 8.10.7
* Ubuntu 20.04.3 LTS

* september spotlight article (#306)

Co-authored-by: Kevin Cislak

* Update creating-wallet-faucet.md (#307)

* Update creating-wallet-faucet.md

* Update creating-wallet-faucet.md

* Delete duplicate article (#310)

* Use `HydraBuildList` to provide latest release binaries (with fallback) (#300)

* Bump prismjs from 1.24.1 to 1.25.0 (#311)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix broken faucet link (#312)

* fix broken faucet link

* Update testnets-and-devnets.md

* Update testnets-and-devnets.md

adding relative paths to the docs/integrate-cardano/testnet-faucet/ url

* Update testnets-and-devnets.md

replaced the problematic url with /docs/whatever as an interim solution just to get the link to work for now

* minor bug (#314)

added the 0x prefix, which is needed for the CLI to recognize the string as a byte array

* Spotlight fixes (#315)

* Fix spotlight article date

* Fix inconsistent tag

* Varia (#320)

* Fix Gimbalab changes

* Add two videos to technical concepts page

* Add PC fund 5 voting results

* Refresh discord invitation link

* Remove outdated note box

* Improve integrate Cardano overview

* Fix inconsistent tAda (test ada) spellings

* Start editorial style guide

* Fix inconsistent ada spellings

* Update Editorial Style Guide

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Matos
Co-authored-by: John Imison 
Co-authored-by: cislakk 
Co-authored-by: Kevin Cislak
Co-authored-by: Javier La Banca 
Co-authored-by: Alexander Klee 
Co-authored-by: AVA 
Co-authored-by: Martin Lang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing Cardano Guide links to outdated pre-built binaries
4 participants