Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tangocrypto #619

Merged
merged 11 commits into from
May 23, 2022
Merged

Tangocrypto #619

merged 11 commits into from
May 23, 2022

Conversation

javiertc
Copy link
Contributor

@javiertc javiertc commented May 18, 2022 •
edited
Loading

Builders tool addition

  • Name: Tangocrypto
  • Description: A suite of high availability APIs and developer tools for fast and reliable access to the Cardano network that requires only 1 minute to integrate.
  • Link: https://www.tangocrypto.com
  • Tags:
    • getstarted
    • api
    • chainindex
    • nft

@javiertc
Copy link
Contributor Author

javiertc commented May 19, 2022 •
edited
Loading

Hi @katomm , @gufmar , @fill-the-fill I hope you are well. Can we get this approved?

@katomm
Copy link
Member

katomm commented May 19, 2022 •
edited
Loading

It's unfortunate that we currently have the deployment previews turned off as we face a problem with Netlify but when I checked out the branch it did not build. (I don't have the error message) Can anyone confirm?

@javiertc
Copy link
Contributor Author

Hi @katomm are able to build that branch locally without any issue.

@javiertc
Copy link
Contributor Author

Hi @katomm can we get an update on this? I've seen approvals to PRs made after this one was submitted. Why the process of adding information to the Cardano developer portal is so slow and cumbersome?

@leobel
Copy link
Contributor

leobel commented May 20, 2022 •
edited
Loading

It's unfortunate that we currently have the deployment previews turned off as we face a problem with Netlify but when I checked out the branch it did not build. (I don't have the error message) Can anyone confirm?

It din't built but you don't have any error message to provide us? We'd like some feedback in order to check the possible error and get this PR approved

rdlrt
rdlrt requested changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I find tangocrypto to be a welcome addition, just a couple of minor claims/wording and potentially a reference to under construction feature needs to be addressed in my view

docs/get-started/tangocrypto.md Outdated Show resolved Hide resolved
docs/get-started/tangocrypto.md Outdated Show resolved Hide resolved
docs/get-started/tangocrypto.md Outdated Show resolved Hide resolved
@javiertc
Copy link
Contributor Author

Hi @rdlrt I just updated the doc following your recommendations 👍🏻

fill-the-fill
fill-the-fill approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@fill-the-fill fill-the-fill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@katomm katomm merged commit e5e535e into cardano-foundation:staging May 23, 2022
katomm pushed a commit that referenced this pull request May 25, 2022
@fill-the-fill @fickevics-makor
@javiertc @leobel @os11k @rdlrt @KtorZ
Merge #621, #622, #624, #626, #619, #625, #627 and #629 into main (#636)
21d5c11 
* Modifying CCVault into Eternl (#621)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add showcase Pool Peek (#622)

* Add pool explorer Pool Peek

* Fix spelling

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add Project Catalyst Fund 7 Voting Results (#624)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add Project Catalyst Fund 8 Voting Results (#626)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Tangocrypto (#619)

* add tangocrypto to builder tool

* Update tangocrypto.md

* add tangocrypto

* add tangocrypto

* add tangocrypto

* update get-started

* remove html list

* change payment with dapp connector wording

* remove nft api

Co-authored-by: Leobel Izquierdo <leobelizquierdo@gmail.com>

* Updated Grafana Dashboard Tutorial (#625)

* Updated Grafana Dashboard Tutorial

Updated Grafana Dashboard Tutorial, now we can have crypto prices inside your Grafa.

* Some typos and minor changes

Some typos and minor changes

* Minor changes typos and etc

* Updated crypto exchange rates chapter 

Updated crypto exchange rates chapter. I tried my best to address @rdlrt concerns. I would like to add that English is just my 3rd language, so I hope it is not too bad.

* Apply suggestions from code review

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>

* Add more technical concepts (#627)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add few more developer tools (#629)

* Address 'TODO': add link to CODE_OF_CONDUCT.md

* add few more developer tools + 'deprecate' csl for cml

Co-authored-by: Fillips Ickevics <60065019+fill-the-fill@users.noreply.github.com>

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>
Co-authored-by: Javier Toledo Cordova <javiertc86@gmail.com>
Co-authored-by: Leobel Izquierdo <leobelizquierdo@gmail.com>
Co-authored-by: Jurijs I <jurijs.ivolga@gmail.com>
Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdlrt rdlrt rdlrt approved these changes

@katomm katomm katomm approved these changes

@fill-the-fill fill-the-fill fill-the-fill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@javiertc @katomm @leobel @rdlrt @fill-the-fill