Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Grafana Dashboard Tutorial #625

Merged
merged 5 commits into from
May 23, 2022
Merged

Updated Grafana Dashboard Tutorial #625

merged 5 commits into from
May 23, 2022

Conversation

os11k
Copy link
Collaborator

@os11k os11k commented May 19, 2022

Updating documentation

Issue

Description of the change

Operate a Stake Pool => Stake Pool Course => Handbook => Grafana Dashboard Tutorial
Added small chapter to Grafana Dashboard Tutorial with steps how we can have crypto prices inside Grafana.

os11k added 3 commits May 19, 2022 22:25
Updated Grafana Dashboard Tutorial, now we can have crypto prices inside your Grafa.
Some typos and minor changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Updated crypto exchange rates chapter. I tried my best to address @rdlrt concerns. I would like to add that English is just my 3rd language, so I hope it is not too bad.
Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried my best to address your remarks, but again English is not my native language, so I hope it is much better now. Thank you!

Thanks @os11k , it's good , I added some suggestions to rewording (apologies, I should've started with that in first response) and paths/variables to make it more consistent with other sections of the page. If you think these are good, you can add them using Add suggestion to batch option in Files Changed tab of the PR

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
@os11k
Copy link
Collaborator Author

os11k commented May 23, 2022

Added @rdlrt suggestions to these PR.

@katomm katomm merged commit 6d55483 into staging May 23, 2022
@katomm katomm deleted the os11k-patch-1 branch May 23, 2022 09:59
katomm pushed a commit that referenced this pull request May 25, 2022
* Modifying CCVault into Eternl (#621)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add showcase Pool Peek (#622)

* Add pool explorer Pool Peek

* Fix spelling

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add Project Catalyst Fund 7 Voting Results (#624)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add Project Catalyst Fund 8 Voting Results (#626)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Tangocrypto (#619)

* add tangocrypto to builder tool

* Update tangocrypto.md

* add tangocrypto

* add tangocrypto

* add tangocrypto

* update get-started

* remove html list

* change payment with dapp connector wording

* remove nft api

Co-authored-by: Leobel Izquierdo <leobelizquierdo@gmail.com>

* Updated Grafana Dashboard Tutorial (#625)

* Updated Grafana Dashboard Tutorial

Updated Grafana Dashboard Tutorial, now we can have crypto prices inside your Grafa.

* Some typos and minor changes

Some typos and minor changes

* Minor changes typos and etc

* Updated crypto exchange rates chapter 

Updated crypto exchange rates chapter. I tried my best to address @rdlrt concerns. I would like to add that English is just my 3rd language, so I hope it is not too bad.

* Apply suggestions from code review

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>

* Add more technical concepts (#627)

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>

* Add few more developer tools (#629)

* Address 'TODO': add link to CODE_OF_CONDUCT.md

* add few more developer tools + 'deprecate' csl for cml

Co-authored-by: Fillips Ickevics <60065019+fill-the-fill@users.noreply.github.com>

Co-authored-by: fill-the-fill <fill.ickevics@gmail.com>
Co-authored-by: Javier Toledo Cordova <javiertc86@gmail.com>
Co-authored-by: Leobel Izquierdo <leobelizquierdo@gmail.com>
Co-authored-by: Jurijs I <jurijs.ivolga@gmail.com>
Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants