Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents node from starting given persisted network state is inconsistent with configuration #1179

Merged
merged 17 commits into from
Nov 28, 2023
Merged

Prevents node from starting given persisted network state is inconsistent with configuration #1179

merged 17 commits into from
Nov 28, 2023

Commits on Nov 27, 2023

  1. Draft e2e spec

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dae4c87 View commit details
    Browse the repository at this point in the history

  2. Capture stderr from child process 

    This is needed in order to see in our test the node has died with a
misconfiguration, which is not the problem we are trying to solve but
which is an important information to have.
    @abailly-iohk @ffakenz
    abailly-iohk authored and ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    201fc45 View commit details
    Browse the repository at this point in the history

  3. Fix draft e2e spec so it fails for the right reason 

    Also renaming the spec to better match the scenarion.
    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d0bd985 View commit details
    Browse the repository at this point in the history

  4. Check when acks dir missmatches with the peers configuration

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    bc98058 View commit details
    Browse the repository at this point in the history

  5. Extend spec to check we can resume a well configured peer

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a172a20 View commit details
    Browse the repository at this point in the history

  6. Parameterize peers connectivity check 

    This is not strictly needed but allows for fine tuning the time we
wait for connection depending on the exact context of the check, and
not blindly on the number of nodes.
    @abailly-iohk @ffakenz
    abailly-iohk authored and ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    08bc46c View commit details
    Browse the repository at this point in the history

  7. Provide a more specific exception for network persistence mismatch

    @abailly-iohk @ffakenz
    abailly-iohk authored and ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    73278b3 View commit details
    Browse the repository at this point in the history

  8. Trace params mismatch missconfiguration error when SavedNetworkPartie… 

    …sInconsistent occur
    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    deb49b0 View commit details
    Browse the repository at this point in the history

  9. Update logs schema with new params mismatch

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    37283d6 View commit details
    Browse the repository at this point in the history

  10. Encapsulate file name in a more explicit function

    @abailly-iohk @ffakenz
    abailly-iohk authored and ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    10609c4 View commit details
    Browse the repository at this point in the history

  11. Add spec namespace when showing logs on failure

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ecd41d4 View commit details
    Browse the repository at this point in the history

  12. Update CHANGELOG

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    49acf78 View commit details
    Browse the repository at this point in the history

  13. Minor formatting fixes

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    813dd54 View commit details
    Browse the repository at this point in the history

  14. Use the function name in the describe scope when unit testing about a… 

    … specific function


This helps in finding relevant tests and eases future renaming of this function.

Co-authored-by: Sebastian Nagel <ch1bo@users.noreply.github.com>
    @ffakenz @ch1bo
    ffakenz and ch1bo committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d7095be View commit details
    Browse the repository at this point in the history

  15. Improve network haddock on configureMessagePersistence

    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    34d9249 View commit details
    Browse the repository at this point in the history

  16. Fix logs description for SavedNetworkPartiesInconsistent by not being… 

    … too concrete
    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1191264 View commit details
    Browse the repository at this point in the history

  17. Improve network spec by avoid writing the internal representation whe… 

    …n saving acks

Instead, we can use the interface provided for 'the system under test', here: configureMessagePersistence.
    @ffakenz
    ffakenz committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3989d2b View commit details
    Browse the repository at this point in the history