-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide git revision as part of hydra-node's version #873
Conversation
Test Results307 tests - 11 301 ✔️ - 11 21m 31s ⏱️ - 2m 25s Results for commit 879604a. ± Comparison against base commit 0607807. This pull request removes 11 tests.
♻️ This comment has been updated with latest results. |
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to point out: The git describe from before would be the last tagged version + # commits + short sha. Now it's always the next release as we bump the .cabal
version whenever we do the code change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we update this test?
CHANGELOG.md
Outdated
+ Users have the option to submit transactions using time validity ranges. | ||
+ Changes to the logs: | ||
- Added current chain slot in OpenState. | ||
- Added current chain slot and time in chain Tick. | ||
|
||
- `hydra-node --version` always displays git revision (SHA) alongside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care that much but if it's easy, I would prefer to not always give the revision (SHA) but only when it's not a released version so that we avoid giving the user too much noise.
But I'm really fine with that already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to have the same opinion. However, we have not found a way to get anything else from the nix flake than the revision. Related issues: NixOS/nix#7201 and NixOS/nix#4682
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine.
a8156a8
to
879604a
Compare
We change the way we display the version number of the hydra-node executable:
0.9.0
) or the output ofgit describe
(0.9.0-23-abeh454
) depending on whether or not the executable was built as a released version or in between releasesFix #849