Refresh tags upon adding a puzzle #722
Conversation
|
Does this fully fix the issue? I haven't tested it but from my understanding the tags are also missing when other people add metas (or if they create new tags in some other way) I think we might want to just refresh the Hunt object periodically, like every 60s or so, similar to what we're doing with refreshing the puzzles. I think this change you're making to refresh it immediately after adding a puzzle is also good for the case when you add a meta and then immediately try to add a feeder puzzle to that meta, though we could check if it's a meta first as an optimization. For correctness we would also want to do an immediate refresh if you edit the puzzle to toggle whether it's a meta, I think. |
|
Yeah that makes sense. I'll add a periodic refresh and also a refresh when you edit tags. |
|
Tested editing a puzzle to change it to a meta and then change it to not a meta. I opened two windows to test the periodic refresh for tags. |
There was a problem hiding this comment.
Actually stepping back for a second (sorry for the churn), does this change make sense to begin with? I kind of feel like what we should be doing is just storing the default tags on the Hunt object (which is fetched once when you load the page and is not expected to change), and then reading the list of available tags from the list of puzzles kind of like we did before:
But that logic can be simplified a lot now to just select all the tags from the Puzzle objects, combine with all the tags on the Hunt object, dedupe and sort by tag id.
Does that make sense?
| @@ -26,6 +27,10 @@ function EditPuzzleModal({ huntId, puzzleId, name, url, isMeta, hasChannels }) { | |||
| }, | |||
| }) | |||
| ).finally(() => { | |||
| // Used to update hunt tags. | |||
| dispatch(fetchHunt(huntId)); | |||
| dispatch(fetchPuzzles(huntId)); | |||
There was a problem hiding this comment.
Don't think this is necessary, is it?
| @@ -23,6 +24,8 @@ function AddPuzzleModal({ huntId }) { | |||
| create_channels: createChannels, | |||
| }) | |||
| ).finally(() => { | |||
| // Used to update hunt tags. | |||
| dispatch(fetchHunt(huntId)); | |||
There was a problem hiding this comment.
I think only if isMeta is true do we need to do this, right?
| @@ -26,6 +27,10 @@ function EditPuzzleModal({ huntId, puzzleId, name, url, isMeta, hasChannels }) { | |||
| }, | |||
| }) | |||
| ).finally(() => { | |||
| // Used to update hunt tags. | |||
| dispatch(fetchHunt(huntId)); | |||
There was a problem hiding this comment.
Same as above, we only need to do this if isMeta is different from newIsMeta right?
| dispatch(fetchPuzzles(props.huntId)); | ||
| dispatch(fetchHunt(props.huntId)); |
There was a problem hiding this comment.
This might add a lot of load if we do it every 10 seconds
|
Yeah that makes sense, I don't have a good sense of how much additional load fetching the hunt object is (since we already fetch puzzles every 10 seconds). From a perf standpoint, I guess ideally we have a websocket connection with which the server pushes updates? It makes sense to me to merge the default tags from the hunt object + custom tags from the puzzles instead. I'll undo these changes and get tags that way. |
|
Closing in favor of #755. |
Address #672.
This re-fetches the hunt slice after adding a puzzle, so the new meta tag appears.