Add puzzle tag selector and merge puzzle + hunt tags. #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgossiaux
approved these changes
Jan 11, 2024
hunts/src/EditPuzzleTagsModal.js
Outdated
Comment on lines
14
to
22
| const huntTags = useSelector(selectHuntTags); | ||
| const puzzleTags = useSelector(selectPuzzleTags); | ||
| // Use a map to concat huntTags and puzzleTags and then dedupe. | ||
| const tagMap = new Map(); | ||
| for (const tag of huntTags.concat(puzzleTags)) { | ||
| tagMap.set(tag.name, tag); | ||
| } | ||
| const allTags = Array.from(tagMap.values()); | ||
|
|
There was a problem hiding this comment.
I think you can dedupe by id instead of name (though since atm tags can't be renamed it's all the same, but I think id is still better)
hunts/src/puzzlesSlice.js
Outdated
| export const selectPuzzleTags = createSelector( | ||
| [puzzlesSelectors.selectAll], | ||
| (puzzles) => { | ||
| // Use a map to dedupe puzzle tags by name. |
akirabaruah
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Add puzzle tag selector and merge them. * Dedupe by id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #672.