Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disclosure indicator #39

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Remove disclosure indicator #39

merged 3 commits into from
Nov 11, 2019

Conversation

agiletalk
Copy link
Contributor

This resolves issue #38.

Spacing on right side is a problem caused by setting a .disclosureIndicator for the accessory type of cell. So I removed it.

And Spacing on left side in landscape is a problem caused by setting insets to Safe Area. This is the default for notch design (iPhone X series)

@cardoso
Copy link
Owner

cardoso commented Oct 15, 2019

Thanks for your contribution @agiletalk !

Is there any way to fix this without removing the disclosure indicator? I think it's important

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #39 into master will decrease coverage by 0.93%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage    70.2%   69.26%   -0.94%     
==========================================
  Files          13       13              
  Lines         443      449       +6     
==========================================
  Hits          311      311              
- Misses        132      138       +6
Impacted Files Coverage Δ
...xMovieDB/Controllers/MovieListViewController.swift 84.31% <45.45%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57d4cb...5871466. Read the comment docs.

@agiletalk
Copy link
Contributor Author

Thanks for your contribution @agiletalk !

Is there any way to fix this without removing the disclosure indicator? I think it's important

I fixed again without removing the disclosure indicator. And I've made some modifications to make it work properly on split view and iPad.

@cardoso
Copy link
Owner

cardoso commented Oct 18, 2019

Thank you @agiletalk ! I'll review as soon as possible

Copy link
Owner

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@cardoso cardoso merged commit cd611b7 into cardoso:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants