-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disclosure indicator #39
Conversation
Thanks for your contribution @agiletalk ! Is there any way to fix this without removing the disclosure indicator? I think it's important |
This reverts commit 74ad3f8.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 70.2% 69.26% -0.94%
==========================================
Files 13 13
Lines 443 449 +6
==========================================
Hits 311 311
- Misses 132 138 +6
Continue to review full report at Codecov.
|
I fixed again without removing the disclosure indicator. And I've made some modifications to make it work properly on split view and iPad. |
Thank you @agiletalk ! I'll review as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help!
This resolves issue #38.
Spacing on right side is a problem caused by setting a .disclosureIndicator for the accessory type of cell. So I removed it.
And Spacing on left side in landscape is a problem caused by setting insets to Safe Area. This is the default for notch design (iPhone X series)