Update for FastBoot 1.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratiahuja
reviewed
May 23, 2017
| let checker = new VersionChecker(this); | ||
| let fastBootVersion = checker.for('ember-cli-fastboot'); | ||
| if (!(fastBootVersion.gte('1.0.0') || fastBootVersion.gte('1.0.0-rc.1'))) { | ||
| let error = new Error(`This version of ember-data-fastboot requires at ember-cli-fastboot above 1.0.0-rc.1, but you have ${fastBootVersion.version}. Revert to the latest 0.0.x version for support for beta versions of ember-cli-fastboot.`); |
There was a problem hiding this comment.
You could just use silent-error instead of explicitly suppressing the stack trace.
There was a problem hiding this comment.
You're right. Used that before. Copy pasted this from ember-cli-version-checker's assert method...
|
@MartinMalinda can we get this merged? |
|
Released in 0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it compatible with the latest ember-cli-fastboot 1.0.0-rc.1. Some context: ember-fastboot/ember-cli-fastboot#387
Here I dropped support for the beta series of FastBoot (where separate browser/fastboot initializers were still available), so these changes only work with FastBoot >= 1.0.0 (-rc.x). As such this should get a minor bump to 0.1.0 when released!