Update OCKContactUtility.swift #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinathtm-apple
approved these changes
Jun 15, 2020
|
Thanks Gary, and congrats on your first contribution to CareKit! |
rutmb
pushed a commit
to tmbiOS/CareKit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCKContactUtility nameFormatter currently uses .medium for the formatter style, which displays given and family names only. Since it is very likely the contacts for Carekit include those in the medical field, i.e., Doctors, it would be more appropriate to use the formatter style .long so that the prefix (Dr.) is included in the formatted string that is displayed.