Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guards #41

Merged
merged 3 commits into from Jul 30, 2020
Merged

Add guards #41

merged 3 commits into from Jul 30, 2020

Conversation

masone
Copy link
Contributor

@masone masone commented Jul 30, 2020

  • don't process flags for requests with extensions (ie assets like robots.txt)
  • don't process flags when there is no user (sane fallback behavior plus gives the getLDUser optional control)

@masone masone requested a review from a team July 30, 2020 06:05
Averethel
Averethel reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@Averethel Averethel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane, but let's add some tests for the edge cases we're trying to solve

src/node.ts Outdated Show resolved Hide resolved
lkappeler
lkappeler approved these changes Jul 30, 2020
View reviewed changes
src/node.ts Outdated Show resolved Hide resolved
@masone masone changed the title Improve handling Add guards Jul 30, 2020
@masone masone merged commit 5845f75 into master Jul 30, 2020
@masone masone deleted the fix-user branch July 30, 2020 12:27
@autoricardo-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Averethel Averethel Averethel left review comments

@lkappeler lkappeler lkappeler approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masone @autoricardo-bot @Averethel @lkappeler