-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binstall tries to build for x86_64-unknown-linux-musl instead of x86_64-unknown-linux-gnu #1420
Comments
Thanks, I will submit a fix for this shortly. It is surprising how glibc from different distro behaves so differently. |
Is there a reason for not always using the same target as |
On NixOS, there isn't a global libc in If someone installed |
Fixed #1420 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Shouldn't a user of such as system configure |
Fixed #1420 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
I was about to post about this same issue. I checked on arch and fedora37 - 39/rawhide and they all have the vanilla Another problem is that fedora ld-linux is under cargo-binstall/crates/detect-targets/src/detect/linux.rs Lines 44 to 46 in 86060fa
|
It seems to me that the target for building shouldn't necessarily be the same as for downloading. |
Thanks for the feedback @JCallicoat @tyilo I will also add PR for lib64 glibc and fallback to |
Fixed #1420 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
* Fix `detect-targets` glibc detection Fixed #1420 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix `detect-targets` glibc detection for Fedora Fedora 37-39 has glibc installed in `/lib64` and `/usr/lib64` instead of `/lib` or `/usr/lib`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Improve caching in `detect-targets-alpine-test` Make sure it reuses cached artifacts instead of recompiling everything. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Mv `test-detect-targets-musl.sh` into `.github/scripts/` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Refactor `ci.yml`: Extract new job `detect-targets-build` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * FIx `detect-targets-ubuntu-test` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Avoid building the entire workspacein `detect-targets-build` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix `detect-targets-*-test`: `chmod +x detect-targets` Also fixed testing on Alpine, to make sure it exits with status 1 on assertion failure. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix typo Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Cache all crates in `detect-targets-build` Since `detect-targets` rarely changes and is quite small, it is also reasonable to cache it. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Add job `detect-targets-more-glibc-test` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Add `detect-targets-nix-test` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix `detect-targets-nix-test` executing `detect-targets` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix workflow: Add all `detect-targets-*` jobs to be dep of `tests-pass` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> --------- Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
I haven't got the
x86_64-unknown-linux-musl
rust target installed, but binstall still tries to use it when building crates from source.I am using Arch Linux.
cargo binstall --verbose rtx-cli
The text was updated successfully, but these errors were encountered: