-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new cmdline option --no-track
#1111
Conversation
5e2f906
to
b79f7a3
Compare
We should use |
Does our implementation also skip the file locking? If so, we should mention it in the help, same as cargo-install does
|
Thanks, I didn't know that
Yes.
I would implement this later. |
b79f7a3
to
b42098c
Compare
0f3b5b3
to
0e0e200
Compare
I've implemented it as requested, but I haven't got time to write the tests yet. |
--no-manifests
--no-track
0e0e200
to
fcd1434
Compare
Same as `cargo-install`'s `--no-track`. It is also passed to `cargo-install` if it is invoked. Also fixed `fs::atomic_symlink_file` which on Windows could fallback to non-atomic install if symlinking failed. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
fcd1434
to
69d0eb6
Compare
I've added e2e test for |
Same as
cargo-install
's--no-track
.It is also passed to
cargo-install
if it is invoked.Also fixed
fs::atomic_symlink_file
which on Windows could fallback tonon-atomic install if symlinking failed.