Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial signing support #1345

Merged
merged 41 commits into from
Sep 23, 2023
Merged

Initial signing support #1345

merged 41 commits into from
Sep 23, 2023

Conversation

passcod
Copy link
Member

@passcod passcod commented Sep 4, 2023

Ref #1

@passcod
Copy link
Member Author

passcod commented Sep 4, 2023

I'm not entirely sure why the test isn't working (ie why the PkgMeta isn't finding the signing section), @NobodyXu mind taking a look? Otherwise I think pretty much all the code is done.

NobodyXu
NobodyXu requested changes Sep 5, 2023
View reviewed changes
crates/bin/src/args.rs Outdated Show resolved Hide resolved
crates/binstalk-fetchers/src/gh_crate_meta.rs Outdated Show resolved Hide resolved
passcod and others added 2 commits September 5, 2023 13:45
@passcod @NobodyXu
Update crates/bin/src/args.rs
f9acd1d 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod @NobodyXu
Update crates/binstalk-fetchers/src/gh_crate_meta.rs
de3f295 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
NobodyXu requested changes Sep 5, 2023
View reviewed changes
crates/bin/src/args.rs Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Sep 5, 2023
View reviewed changes
crates/binstalk-fetchers/src/gh_crate_meta.rs Show resolved Hide resolved
crates/binstalk-fetchers/src/signing.rs Outdated Show resolved Hide resolved
crates/binstalk-fetchers/src/signing.rs Outdated Show resolved Hide resolved
crates/binstalk-fetchers/src/signing.rs Outdated Show resolved Hide resolved
crates/binstalk-fetchers/src/signing.rs Outdated Show resolved Hide resolved
crates/binstalk-fetchers/src/signing.rs Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Sep 5, 2023
View reviewed changes
crates/binstalk-fetchers/src/quickinstall.rs Show resolved Hide resolved
e2e-tests/signing.sh Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Sep 5, 2023
View reviewed changes
crates/binstalk/src/ops/resolve.rs Outdated Show resolved Hide resolved
passcod and others added 8 commits September 5, 2023 15:58
@passcod @NobodyXu
Update crates/bin/src/args.rs
98ed25b 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod @NobodyXu
Update crates/binstalk-fetchers/src/signing.rs
f2bd890 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod @NobodyXu
Update crates/binstalk-fetchers/src/signing.rs
5b97175 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod @NobodyXu
Update crates/binstalk-fetchers/src/signing.rs
031b822 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod @NobodyXu
Update crates/binstalk-fetchers/src/signing.rs
b562606 
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
@passcod
fixes
0422bb9
@passcod
Finish feature
3d10c84
@passcod
Document
eaa68cc
@passcod passcod marked this pull request as ready for review September 6, 2023 08:31
NobodyXu
NobodyXu requested changes Sep 6, 2023
View reviewed changes
crates/binstalk-fetchers/src/gh_crate_meta.rs Show resolved Hide resolved
crates/binstalk-fetchers/src/gh_crate_meta.rs Outdated Show resolved Hide resolved
crates/binstalk-fetchers/src/gh_crate_meta.rs Outdated Show resolved Hide resolved
crates/binstalk/src/ops/resolve.rs Outdated Show resolved Hide resolved
@NobodyXu NobodyXu mentioned this pull request Sep 17, 2023
Merged
NobodyXu
NobodyXu requested changes Sep 23, 2023
View reviewed changes
e2e-tests/signing.sh Outdated Show resolved Hide resolved
@NobodyXu
Copy link
Member

NobodyXu commented Sep 23, 2023 •
edited

ok so the macos CI failed due to connection error to the http server.
I would probably push directly to this branch later to solve the issue.

@NobodyXu
Fix e2e-tests/signing.sh MacOS CI failure
c52fb74 
Move the tls cert creation into `signing.sh` and sleep for 10s to wait
for https server to start.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Refactor e2e-tests-signing files
cff9275 
 - Use a tempdir generated by `mktemp` for all certificates-related
   files
 - Put other checked-in files into `e2e-tests/signing`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fixed e2e-tests-signing connection err in MacOS CI
c456530 
Wait for server to start up by trying to connect to it.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix e2e-tests-signing passing -subj to openssl on Windows
40be0c9 
Use single quote instead of double quote to avoid automatic expansion
from bash

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix e2e-tests-signing waiting for server to startup
40641a6 
Remove `timeout` since it is not supported on MacOS.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Try to fix windows CI by setting MSYS_NO_PATHCONV=1 on openssl cmds
6188289 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fixed e2e-tests-signing on windows
a12783c 
By using double `//` for the value passed to option `-subj`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fixed infinite loop in signing/wait-for-server on Windows
640b05d 
Pass `--ssl-revoke-best-effort` to prevent schannel from checking ssl
revocation status.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add cap on retry attempt in signing/wait-for-server.sh
a7e03c3 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Let singing/server.py print output to stderr
c4bf310 
so that we can see the error message there.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix running signing/server.py on MacOS CI
f7e0649 
use `python3` since macos-latest still has python2 installed and
`python` is a symlink to `python2` there.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu added this pull request to the merge queue Sep 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Sep 23, 2023
Merged via the queue into main with commit 32beba5 Sep 23, 2023
30 checks passed
@NobodyXu NobodyXu deleted the initial-signing-support branch September 23, 2023 04:16
@passcod
Copy link
Member Author

passcod commented Sep 23, 2023

Thanks for finishing this :)

This was referenced Sep 25, 2023
Merged
Merged
Closed
Merged
@NobodyXu NobodyXu mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsan simonsan simonsan left review comments

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@passcod @NobodyXu @simonsan