Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest #228

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Update manifest #228

merged 3 commits into from
Sep 17, 2023

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Sep 17, 2023

Auto-generated by create-pull-request

@NobodyXu NobodyXu enabled auto-merge (squash) September 17, 2023 12:39
@NobodyXu NobodyXu merged commit d7013fb into main Sep 17, 2023
26 checks passed
@NobodyXu NobodyXu deleted the update-manifest branch September 17, 2023 12:46
@NobodyXu
Copy link
Collaborator

@taiki-e Just to let you know, we at cargo-binstall are now working on:

@taiki-e
Copy link
Owner Author

taiki-e commented Sep 17, 2023

Great!

Signing pre-built binaries of cargo-binstall,

Which files will be signed? In any case, I think we can support that on the codegen side 1, but it would probably be easiest if it is a checksum file or an archive.

Footnotes

  1. We can extend the codegen to ensure that the hash in the generated manifest is the same as that obtained from the signed archive or indicated in the signed checksum file. This allows signature verification to be performed without additional cost at the time of execution of the action.

@NobodyXu
Copy link
Collaborator

All pre-built binaries (tarballs) in cargo-binstall release will be signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants