Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detect-targets glibc detection #1421

Merged
merged 14 commits into from
Sep 30, 2023
Merged

Fix detect-targets glibc detection #1421

merged 14 commits into from
Sep 30, 2023

Commits on Sep 29, 2023

  1. Fix detect-targets glibc detection 

    Fixed #1420

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8c093c7 View commit details
    Browse the repository at this point in the history

  2. Fix detect-targets glibc detection for Fedora 

    Fedora 37-39 has glibc installed in `/lib64` and `/usr/lib64` instead of
`/lib` or `/usr/lib`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fcf5e8e View commit details
    Browse the repository at this point in the history

  3. Improve caching in detect-targets-alpine-test 

    Make sure it reuses cached artifacts instead of recompiling everything.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a71b698 View commit details
    Browse the repository at this point in the history

  4. Mv test-detect-targets-musl.sh into .github/scripts/ 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0d111ee View commit details
    Browse the repository at this point in the history

  5. Refactor ci.yml: Extract new job detect-targets-build 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c81740f View commit details
    Browse the repository at this point in the history

  6. FIx detect-targets-ubuntu-test 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    58545af View commit details
    Browse the repository at this point in the history

  7. Avoid building the entire workspacein detect-targets-build 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    09d94d3 View commit details
    Browse the repository at this point in the history

  8. Fix detect-targets-*-test: chmod +x detect-targets 

    Also fixed testing on Alpine, to make sure it exits with status 1 on
assertion failure.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    79a9390 View commit details
    Browse the repository at this point in the history

  9. Fix typo 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b4075ca View commit details
    Browse the repository at this point in the history

  10. Cache all crates in detect-targets-build 

    Since `detect-targets` rarely changes and is quite small, it is also
reasonable to cache it.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a045b1e View commit details
    Browse the repository at this point in the history

  11. Add job detect-targets-more-glibc-test 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    066321a View commit details
    Browse the repository at this point in the history

  12. Add detect-targets-nix-test 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    46e3e2e View commit details
    Browse the repository at this point in the history

  13. Fix detect-targets-nix-test executing detect-targets 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9f5c024 View commit details
    Browse the repository at this point in the history

  14. Fix workflow: Add all detect-targets-* jobs to be dep of tests-pass 

    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    @NobodyXu
    NobodyXu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    22bb399 View commit details
    Browse the repository at this point in the history