Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tar by temporarily using a fork #358

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Fix tar by temporarily using a fork #358

merged 1 commit into from
Sep 10, 2022

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Sep 10, 2022

Temporary solution for #177

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu NobodyXu marked this pull request as ready for review September 10, 2022 04:20
@NobodyXu NobodyXu added the PR: bugfix PR that fixes a bug label Sep 10, 2022
@NobodyXu NobodyXu enabled auto-merge (squash) September 10, 2022 04:20
@passcod
Copy link
Member

passcod commented Sep 10, 2022

Mmm we definitely want to publish that to crates. Installing via cargo install cargo-binstall must be preserved! Happy to merge if that's for a starting point and we'll publish/update this later.

@NobodyXu
Copy link
Member Author

Mmm we definitely want to publish that to crates. Installing via cargo install cargo-binstall must be preserved! Happy to merge if that's for a starting point and we'll publish/update this later.

I'm not very familiar with cargo install a crate with git dependency.
Does having a git dependency prevents cargo-install?

Personally I'd like to avoid publishing it as it would be temporary and I don't want it to take up precious name on crates.io, but if cargo install cargo-binstall requires publishing it then I would do it.

@passcod
Copy link
Member

passcod commented Sep 10, 2022

We just can't publish to crates if there are non-crates dependencies, that's a registry-wide policy. (The rationale behind it is that the registry is conceptually immutable (you can mark a package as yanked but that doesn't remove it), and git isn't. You must always be able to download a crate and all its dependencies, and that's only possible if all of them are in the registry.)

@NobodyXu
Copy link
Member Author

We just can't publish to crates if there are non-crates dependencies, that's a registry-wide policy. (The rationale behind it is that the registry is conceptually immutable (you can mark a package as yanked but that doesn't remove it), and git isn't. You must always be able to download a crate and all its dependencies, and that's only possible if all of them are in the registry.)

Got it, I would publish it then under the name binstall-tar.

@NobodyXu NobodyXu force-pushed the fix/tar branch 3 times, most recently from e3a7897 to 73b9da1 Compare September 10, 2022 05:54
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Copy link
Member Author

@passcod Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bugfix PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants