-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetcher::QuickInstall
stats report sending
#918
Conversation
…darwin since quickinstall only supports targets officially supports by rust. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
…ait`ed on Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Does the latter point still send reports when installing from source? |
also while thinking of it, we should support universal2-apple-darwin, which is the convention for arm+intel in another ecosystem, iirc python (to differentiate with the earlier universal for powerpc+intel) |
If quickinstall is not disabled by strategy, then yes, every |
Does that mean we need to rename Or do we just create a new alias? |
Just a new alias, it's only convention anyway. |
Fixed cargo-bins/cargo-quickinstall#195
Fix
fetchers::QuickInstall
: Stop sending stats foruniversal-apple-darwin
since quickinstall only supports targets officially supports by rust.
Only send stats report to quickinstall if the
Fetcher::find
is.await
ed onThis prevents stats report to be sent for cases where the
QuickInstall
fetcheris actually unused, e.g. resolved to
GhCrateMeta
or otherQuickInstall
fetcherwith different target.
This also reduces amount of http requests created in background.
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com