Simplify unix implementation #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove second param of `set_nonblocking` since it is always set to `true` - Remove `is_pipe_without_access_mode_check`, change `is_pipe` to only take one parameter and add fn `get_access_mode` for checking access mode separately. - Use `ManuallyDrop::new(File::from_raw_fd(..))` to construct a `File` with no `Drop` so that we can call its `metadata()` and its `try_clone()` fn without having to implement them ourselves using `unsafe` code in `dup*`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_nonblockingsince it is always set totrueis_pipe_without_access_mode_check, changeis_pipeto only take one parameter and add fnget_access_modefor checking access mode separately.ManuallyDrop::new(File::from_raw_fd(..))to construct aFilewith noDropso that we can call itsmetadata()and itstry_clone()fn without having to implement them ourselves usingunsafecode indup*.O_RDWRshould also be accepted.