Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_nonblocking
since it is always set totrue
is_pipe_without_access_mode_check
, changeis_pipe
to only take one parameter and add fnget_access_mode
for checking access mode separately.ManuallyDrop::new(File::from_raw_fd(..))
to construct aFile
with noDrop
so that we can call itsmetadata()
and itstry_clone()
fn without having to implement them ourselves usingunsafe
code indup*
.O_RDWR
should also be accepted.