Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets: Server side ping, disconnect clients that don't respond after X attempts #129

Closed
sdg9 opened this issue May 21, 2022 · 0 comments · Fixed by #143
Closed

Sockets: Server side ping, disconnect clients that don't respond after X attempts #129

sdg9 opened this issue May 21, 2022 · 0 comments · Fixed by #143
Assignees
@sdg9
Labels
enhancement New feature or request

Comments

@sdg9
Copy link
Collaborator

sdg9 commented May 21, 2022

No description provided.

@sdg9 sdg9 added the enhancement New feature or request label May 21, 2022
@sdg9 sdg9 self-assigned this May 21, 2022
sdg9 added a commit to sdg9/mezzo that referenced this issue May 26, 2022
@sdg9
fix(web sockets): server detects disconnected clients and closes them
07612b8 
server uses ping/pong approach to detect when a client is no longer connected and remove them if
stale

fix caribou-crew#129
@sdg9 sdg9 mentioned this issue May 26, 2022
Merged
NSwanson1 pushed a commit that referenced this issue May 27, 2022
@sdg9
fix(web sockets): server detects disconnected clients and closes them (…
1ca24ab 
…#143)

* fix(web sockets): server detects disconnected clients and closes them

server uses ping/pong approach to detect when a client is no longer connected and remove them if
stale

fix #129

* test(record-ws): ignore ping messages

* test: attempt to fix tests

* test: fix test flakiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdg9 sdg9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(web sockets): server detects disconnected clients and closes them sdg9/mezzo
1 participant
@sdg9