Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix peer dependencies #103

Merged
merged 1 commit into from
May 12, 2022

Conversation

sdg9
Copy link
Collaborator

@sdg9 sdg9 commented May 12, 2022

  • react-native is not required as it's a peer dependency of interceptor-react-native-with-reactotron
    • it didn't like the project using react 18.x.x as only 17 is a valid peer dependency
  • use fork of react-reflex that lists react 18.x.x as a supported peer dependency to avoid errors during npm install

Before

➜  mezzo git:(main) npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: react-native@0.68.1
npm ERR! Found: react@18.1.0
npm ERR! node_modules/react
npm ERR!   react@"18.1.0" from the root project
npm ERR!   peer react@">=16.8.0" from @emotion/react@11.9.0
npm ERR!   node_modules/@emotion/react
npm ERR!     @emotion/react@"^11.9.0" from the root project
npm ERR!     peer @emotion/react@"^11.0.0-rc.0" from @emotion/styled@11.8.1
npm ERR!     node_modules/@emotion/styled
npm ERR!       @emotion/styled@"^11.8.1" from the root project
npm ERR!       3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR!     3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR!   18 more (@emotion/styled, @mui/base, @mui/icons-material, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.2" from react-native@0.68.1
npm ERR! node_modules/react-native
npm ERR!   react-native@"^0.68.1" from the root project
npm ERR!   peer react-native@"*" from @react-native-community/cli@7.0.3
npm ERR!   node_modules/@react-native-community/cli
npm ERR!     @react-native-community/cli@"^7.0.3" from react-native@0.68.1
npm ERR!
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@"17.0.2" from react-native@0.68.1
npm ERR!   node_modules/react-native
npm ERR!     react-native@"^0.68.1" from the root project
npm ERR!     peer react-native@"*" from @react-native-community/cli@7.0.3
npm ERR!     node_modules/@react-native-community/cli
npm ERR!       @react-native-community/cli@"^7.0.3" from react-native@0.68.1
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/stevengoff/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/stevengoff/.npm/_logs/2022-05-12T20_09_53_347Z-debug-0.log

After

➜  mezzo git:(sdg9/fixDependencies) npm i

up to date, audited 1973 packages in 8s

200 packages are looking for funding
  run `npm fund` for details

3 critical severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

@nx-cloud
Copy link

nx-cloud bot commented May 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f760070. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@Gonzalo8642 Gonzalo8642 merged commit 0f41b02 into caribou-crew:main May 12, 2022
@sdg9 sdg9 deleted the sdg9/fixDependencies branch May 24, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants