Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python scenario in carla_ros_scenario_runner #396

Closed
wants to merge 3 commits into from
Closed

Support python scenario in carla_ros_scenario_runner #396

wants to merge 3 commits into from

Conversation

jeonghoahn42
Copy link

@jeonghoahn42 jeonghoahn42 commented Oct 20, 2020

image

  • make carla_ros_scenario_runner.py to publish CarlaScenarioList by parsing available_scenarios_json

  • carla_ros_scenario_runner_types/CarlaScenario.msg support python scenario additionally

    • (prev) property scenario_file -> scenario_runner.py --openscenario=scenario_file
    • (added) property scenario -> scenario_runner.py --scenario=scenario
      • optional properties additional_scenario and config_file -> --additionalScenario=additional_scenario --configFile=config_file
  • search all scenario-related files in available_scenarios_dir

  • support fixed_delta_seconds = 0 in roslaunch, to support variable time-step in asyncronous mode


This change is Reviewable

@hofbi
Copy link
Contributor

hofbi commented Nov 25, 2020

Do you plan to integrate this feature? Would be great if you could rebase to the latest master to prepare this for the review.

@jeonghoahn42
Copy link
Author

I rebased to latest master. could you review this change?

@joel-mb joel-mb assigned joel-mb and unassigned joel-mb Nov 27, 2020
@joel-mb joel-mb self-requested a review November 27, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants