Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle URI's containing a comma character #28

Closed
branislavzelenak opened this issue Oct 23, 2020 · 3 comments · Fixed by #29
Closed

Handle URI's containing a comma character #28

branislavzelenak opened this issue Oct 23, 2020 · 3 comments · Fixed by #29

Comments

@branislavzelenak
Copy link

branislavzelenak commented Oct 23, 2020

Hello, in our system we have a common appearance of a live stream HLS master playlist that contains a comma character (for rerouting between streamers/servers) in URIs, like so:

`
#EXTM3U
#EXT-X-VERSION:7
#EXT-X-INDEPENDENT-SEGMENTS
#EXT-X-STREAM-INF:BANDWIDTH=1496000,FRAME-RATE=25.000,RESOLUTION=856x480
http://5.22.186.164:8080/stream/?fw=true&route=sbb-bg-ku-h1-22,sbb-bg-ne-h1-14&rule=11,null&sp=unitedcloud&asset=masaimedved102srb-hd-p-srpsub&stream=hp1400&conn=UNKNOWN&nf=3&b=3&player=m3u8v&t=36000&adaptive=false&orig=true

#EXT-X-STREAM-INF:BANDWIDTH=446000,FRAME-RATE=25.000,RESOLUTION=512x288
http://5.22.186.164:8080/stream/playlist/hls/?session=e02569a4-5fee-4503-81a2-03ffd859c193&stream=hp350&player=m3u8v

#EXT-X-STREAM-INF:BANDWIDTH=3596000,FRAME-RATE=25.000,RESOLUTION=1920x1080
http://5.22.186.164:8080/stream/playlist/hls/?session=e02569a4-5fee-4503-81a2-03ffd859c193&stream=hp3500&player=m3u8v

#EXT-X-STREAM-INF:BANDWIDTH=7096000,FRAME-RATE=25.000,RESOLUTION=1920x1080
http://5.22.186.164:8080/stream/playlist/hls/?session=e02569a4-5fee-4503-81a2-03ffd859c193&stream=hp7000&player=m3u8v
`

We love using your library, however the URL of the first variant list here is read only until the first ',' character, and thus is incomplete. Would you consider patching so that these kind of URI's are handled properly?

Thanks and keep up the excellent work and contribution!

@carlanton
Copy link
Owner

Hi! Thank you for reporting this bug. It was caused by how the parser handled the url internally. It's now fixed and will be released asap :)

@branislavzelenak
Copy link
Author

Hi, that's great, thanks! Please let me know here when you release it on gradle so we can update locally :)

@branislavzelenak
Copy link
Author

I've seen you already released 0.17, it works fine, so thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants