Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack in experimental branch takes over scroll-page keymap. #330

Closed
kiko opened this issue Dec 22, 2011 · 9 comments
Closed

Ack in experimental branch takes over scroll-page keymap. #330

kiko opened this issue Dec 22, 2011 · 9 comments

Comments

@kiko
Copy link

kiko commented Dec 22, 2011

In Vim <C-F> and <C-f> are synonymous, thus current Ack plugin configuration takes over default page scrolling.

  " Control-Shift-F on other systems
  call janus#add_mapping('ack', 'map', '<C-F>', ':Ack<space>')

https://github.com/carlhuda/janus/blob/experimental/janus/vim/tools/janus/after/plugin/ack.vim#L6

@kalbasit
Copy link
Member

I'll test that later on my linux box, on mac <D-F> and <D-f> are not the same

@kiko
Copy link
Author

kiko commented Dec 23, 2011

Thanks. I think you can confirm the behavior on OS X's default vim (/usr/bin/vim) as well.

@kalbasit
Copy link
Member

I confirm this, apparently on some OSes ViM has some limitations when using the Ctrl key in the mapping, see this thread for more information..

What do you suggest for the keymapping ?

@kiko
Copy link
Author

kiko commented Dec 25, 2011

Honestly, I couldn't come up with a good one. Alt brings another incompatibility with console vim.
Also, <A-F> doesn't seem to work with gVim. (becuase <A-f> binds to open File menu?)
Personally I'd map with <leader> but since <D-F> is used for MacVim, I assume you want something consistent.

@kalbasit
Copy link
Member

Yes sadly we need something consistent, I'll look into it.

@tapster
Copy link

tapster commented Dec 31, 2011

this issue seems to be in the master branch too, not just experimental: https://github.com/carlhuda/janus/blob/master/janus/vim/tools/janus/after/plugin/ack.vim

using OSX vim not macvim

@kalbasit
Copy link
Member

kalbasit commented Jan 3, 2012

Yes experimental was merged recently into master.

kalbasit added a commit that referenced this issue Jan 3, 2012
kalbasit added a commit that referenced this issue Jan 3, 2012
@kalbasit
Copy link
Member

kalbasit commented Jan 3, 2012

I just added a little hack to find out if we are taking over the default behavior of <C-f> and if we are, it is bound to <leader>f, please let me know if it does not work.

@kalbasit kalbasit closed this as completed Jan 3, 2012
@tapster
Copy link

tapster commented Jan 3, 2012

works for me OSX + vim in iTerm. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants