New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for julia v0.6 #42

Closed

adambrewster wants to merge 4 commits into carlobaldassi:master from adambrewster:master

adambrewster commented Mar 10, 2017

I hacked together some changes to get this working on v0.6 before I saw #40.

It's not perfect. Deprecation warnings remain. The @doc fix is particularly bad. The tests pass (for me) on julia 0.5.1 and some version of v0.6 that I happen to have checked out and built today.

adambrewster added 4 commits

March 10, 2017 11:47


          julia 0.5 call syntax

6015e23


          These tests are a bit tight. Let julia print arrays any way that it l…

7c8ff77

…ikes.


          julia >= 0.6 turns bare strings into calls to @doc.

873591a

I don't get the macrocall syntax, and that `&& true` should really check
if this is really an @doc, but I don't know how to do that.  This gets
the tests to pass.


          Carriage returns make it hard to see what's wrong when the tests fail.

51b72cd

coveralls commented Mar 10, 2017 •

edited

Coverage increased (+0.02%) to 94.514% when pulling 51b72cd on adambrewster:master into 22f6672 on carlobaldassi:master.

4 similar comments

coveralls commented Mar 10, 2017

Coverage increased (+0.02%) to 94.514% when pulling 51b72cd on adambrewster:master into 22f6672 on carlobaldassi:master.

coveralls commented Mar 10, 2017

Coverage increased (+0.02%) to 94.514% when pulling 51b72cd on adambrewster:master into 22f6672 on carlobaldassi:master.

coveralls commented Mar 10, 2017

Coverage increased (+0.02%) to 94.514% when pulling 51b72cd on adambrewster:master into 22f6672 on carlobaldassi:master.

coveralls commented Mar 10, 2017

Coverage increased (+0.02%) to 94.514% when pulling 51b72cd on adambrewster:master into 22f6672 on carlobaldassi:master.

codecov-io commented Mar 10, 2017

Codecov Report

Merging #42 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   94.49%   94.51%   +0.01%     
==========================================
  Files           1        1              
  Lines        1108     1112       +4     
==========================================
+ Hits         1047     1051       +4     
  Misses         61       61

Impacted Files	Coverage Δ
src/ArgParse.jl	`94.51% <100%> (+0.01%)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f6672...51b72cd. Read the comment docs.

carlobaldassi added a commit that referenced this pull request


          Fix tests to pass on 0.6

0ca8d6e

This fix is due to @adambrewster, taken from #42

carlobaldassi mentioned this pull request

WIP: Fixes for v0.6 #40

Closed

Owner

carlobaldassi commented Apr 23, 2017

Thanks, I took some things from here and some from #40, and fixed the remaining issues on 0.6.

carlobaldassi closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment