resolve host only if not an ip

carlos8f · Jun 14, 2013 · 226e330 · 226e330
1 parent 2e28324
commit 226e330
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/lib/node.js b/lib/node.js
@@ -21,14 +21,19 @@ function Node(spec, options) {
     self.options[k] = options[k];
   });
 
-  // Resolve host, to prevent false duplication
-  Node.resolveHost(this.host, function(err, host) {
-    if (err) {
-      return self.emit('error', err);
-    }
-    self.host = host;
-    self.connect();
-  });
+  if (this.host.match(/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/)) {
+    this.connect();
+  }
+  else {
+    // Resolve host, to prevent false duplication
+    Node.resolveHost(this.host, function(err, host) {
+      if (err) {
+        return self.emit('error', err);
+      }
+      self.host = host;
+      self.connect();
+    });
+  }
 }
 util.inherits(Node, EventEmitter);
 

diff --git a/test/_common.js b/test/_common.js
@@ -9,7 +9,7 @@ idgen = require('idgen');
 path = require('path');
 
 servers = {};
-ports = [6380, 6381, 6382];
+ports = ['127.0.0.1:6380', 'localhost:6381', 6382];
 testId = null;
 
 makeServer = function (port, cb) {
@@ -49,6 +49,7 @@ makeServers = function (cb) {
   testId = idgen(4);
   var tasks = {};
   ports.forEach(function (port) {
+    if (typeof port === 'string') port = Number(port.split(':')[1]);
     tasks[port] = makeServer.bind(null, port);
   });