Bump action Node version to v20 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @LukasTy . Thank you for this. Sorry for the late reply. Do you mind rebase your PR and fix conflicts? And yes, there is no need to commit the output of the build command. |
|
Hey @carloscastrojumo |
carloscastrojumo
approved these changes
Mar 27, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 16 is deprecated on GitHub actions.
Running this action produces the following warning:
https://github.com/mui/mui-x/actions/runs/7956989267
Changes
usingtonode20instead ofnode16(other actions treated this change as a major release)BumpAlready done via a separate PR@types/nodeto v20UpdateAlready done via a separate PR@actions/coreand@actions/ioto the latest versions@octokit/webhooks-definitionswith@octokit/webhooks-typesas the former is already deprecatedformatQuestion
Do I need to
run buildand commit the updated built file or is release handled separately? 🤔