Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should gitmoji be platform agnostic? #452

Closed
vhoyer opened this issue Jun 8, 2020 · 16 comments · Fixed by #471
Closed

Should gitmoji be platform agnostic? #452

vhoyer opened this issue Jun 8, 2020 · 16 comments · Fixed by #471
Labels
breaking-change discussion Discussions about the proposal of an emoji.

Comments

@vhoyer
Copy link
Collaborator

vhoyer commented Jun 8, 2020

Hello, 😎!

So I noticed there are some discussion around here around if we should or not add more technology specific emojis like shell script#432, storybook#325, or that disscussion on changing the 🐳#287.

I think we should disscus "formally" if we want to keep adding more platform/technology specific emojis, to not only come to a common decission about it, but also be an issue that we can point people when they suggest more of those, maybe event have this on the readme :D

So, should gitmoji be platform agnostic?

@vhoyer
Copy link
Collaborator Author

vhoyer commented Jun 8, 2020

So let me begin :D

I don't think we should :D platforms and technologies die, gitmoji should live forever 😂, not only that but adding too much platform specific emojis adds complexity to newcomers to gitmoji making it harder to grasp or at least scaring people away from the emojis (#352) 🌈.

@johannchopin johannchopin added the discussion Discussions about the proposal of an emoji. label Jun 8, 2020
@johannchopin
Copy link
Collaborator

Totally agree with your point of view @vhoyer. Having platform agnostic gitmojis will end up by having hundred of new gitmojis proposition for each platforms/libraries/frameworks/plugins/modules/...

I think thats a 'good' gitmojis can be used in multiples projects environnement (web/system/server-side/design/...) wich is for example not the case of ☸️ which only refer to k8s technologie.

@vhoyer vhoyer pinned this issue Jun 8, 2020
@KaKi87
Copy link
Contributor

KaKi87 commented Jun 11, 2020

I agree, I think we should drop and stop adding platforms, but still keep operating systems, because they aren't much of them : Windows, Linux, Mac, Android, iOS. They can be often useful.

@johannchopin
Copy link
Collaborator

johannchopin commented Jun 11, 2020

I don't think that 'they aren't much of them' is a valid argument to keep them @KaKi87 🤔 Why create a 'rule' that we don't apply ?

@KaKi87
Copy link
Contributor

KaKi87 commented Jun 11, 2020

What about 'they can be often useful' ?
In any multiplatform project there can be OS-specific issues.

@johannchopin
Copy link
Collaborator

Still an edge case of 🐛. In a web project should we have all gitmojis for JavaScript, css html ?

@KaKi87
Copy link
Contributor

KaKi87 commented Jun 11, 2020

OSes, not platforms nor languages.
Independently of your platform and programming language, you can have OS-specific issues.

@vhoyer
Copy link
Collaborator Author

vhoyer commented Jun 11, 2020

I would agree in leaving the ones we have due to backwards compatibility :D

EDIT: typo

@johannchopin
Copy link
Collaborator

@vhoyer I will recommend to make them as deprecated. If people want to use them it would be their own choice (emoji itself will still be render properly by the platforms).

@vhoyer
Copy link
Collaborator Author

vhoyer commented Jun 11, 2020

yeah, but how would we pass this information? I don't like the idea of having deprecated emojis 🤔 I prefer the idea of removing. I know this is contradictory compared with my last comment, but in the last comment I was just proposing a compromise :D

EDIT: ✏️ typo 😅

@carloscuesta
Copy link
Owner

I think that we can drop them since as you said those emojis are covered by a generic one.

For example:

🐛 -> it’s the same as Fixing something on iOS / Windows / Android

So, let’s create a list of the emojis that we are going to remove that are platform based and lets raise a PR

@vhoyer
Copy link
Collaborator Author

vhoyer commented Jun 13, 2020

Ok, than this issue is set, we will not have anymore emojis added that are platform based, I will close this PR and reference it on all the other suggestions(issues) to add platform emojis. 😄

the discussion of removing the emojis, I think can be covered by #435 :D

@KaKi87
Copy link
Contributor

KaKi87 commented Jun 14, 2020

I think there are many others that would be removable we really intent to strictly keep only generic gitmojis.

@johannchopin
Copy link
Collaborator

Lets finalize the list of gitmojis that have to be removed:

  • 🍎
  • 🐧
  • 🏁
  • 🤖
  • 🍏
  • 🐳
  • ☸️

Please add a comment if I missed one 👍

@johannchopin johannchopin reopened this Jun 14, 2020
@carloscuesta
Copy link
Owner

I think you listed all of them @johannchopin.

Once we merge that removal, we should make a new release of Gitmoji and publish it to npm sincey it's a breaking change 👍

@vhoyer vhoyer added this to To do in Gitmoji Kanban via automation Jun 15, 2020
@johannchopin
Copy link
Collaborator

If we remove 🐳 I think that we have to first add a new gitmoji related to containers what do you think? There's already been a proposal in #298.

@johannchopin johannchopin mentioned this issue Jun 18, 2020
1 task
@johannchopin johannchopin moved this from To do to In progress in Release 2.0.0 Jun 23, 2020
johannchopin added a commit to johannchopin/gitmoji that referenced this issue Jun 24, 2020
Release 2.0.0 automation moved this from In progress to Done Jun 26, 2020
BrikerMan added a commit to BrikerMan/gitmoji-cn that referenced this issue Jul 10, 2020
According to the ([carloscuesta#452](carloscuesta#452)), Removing emojis
 
- 🍎: Fixing something on macOS.
- 🐧: Fixing something on Linux.
- 🏁: Fixing something on Windows.
- 🤖: Fixing something on Android.
- 🍏: Fixing something on iOS.
- 🐳: Work about Docker.
- 👌: Updating code due to code review changes.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change discussion Discussions about the proposal of an emoji.
Projects
No open projects
Release 2.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants