New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should gitmoji be platform agnostic? #452
Comments
So let me begin :D I don't think we should :D platforms and technologies die, gitmoji should live forever 😂, not only that but adding too much platform specific emojis adds complexity to newcomers to gitmoji making it harder to grasp or at least scaring people away from the emojis (#352) 🌈. |
Totally agree with your point of view @vhoyer. Having platform agnostic gitmojis will end up by having hundred of new gitmojis proposition for each platforms/libraries/frameworks/plugins/modules/... I think thats a 'good' gitmojis can be used in multiples projects environnement (web/system/server-side/design/...) wich is for example not the case of ☸️ which only refer to k8s technologie. |
I agree, I think we should drop and stop adding platforms, but still keep operating systems, because they aren't much of them : Windows, Linux, Mac, Android, iOS. They can be often useful. |
I don't think that 'they aren't much of them' is a valid argument to keep them @KaKi87 🤔 Why create a 'rule' that we don't apply ? |
What about 'they can be often useful' ? |
Still an edge case of 🐛. In a web project should we have all gitmojis for JavaScript, css html ? |
OSes, not platforms nor languages. |
I would agree in leaving the ones we have due to backwards compatibility :D EDIT: typo |
@vhoyer I will recommend to make them as deprecated. If people want to use them it would be their own choice (emoji itself will still be render properly by the platforms). |
yeah, but how would we pass this information? I don't like the idea of having deprecated emojis 🤔 I prefer the idea of removing. I know this is contradictory compared with my last comment, but in the last comment I was just proposing a compromise :D EDIT: ✏️ typo 😅 |
I think that we can drop them since as you said those emojis are covered by a generic one. For example: 🐛 -> it’s the same as Fixing something on iOS / Windows / Android So, let’s create a list of the emojis that we are going to remove that are platform based and lets raise a PR |
Ok, than this issue is set, we will not have anymore emojis added that are platform based, I will close this PR and reference it on all the other suggestions(issues) to add platform emojis. 😄 the discussion of removing the emojis, I think can be covered by #435 :D |
I think there are many others that would be removable we really intent to strictly keep only generic gitmojis. |
Lets finalize the list of gitmojis that have to be removed:
Please add a comment if I missed one 👍 |
I think you listed all of them @johannchopin. Once we merge that removal, we should make a new release of Gitmoji and publish it to npm sincey it's a breaking change 👍 |
If we remove 🐳 I think that we have to first add a new gitmoji related to containers what do you think? There's already been a proposal in #298. |
According to the ([carloscuesta#452](carloscuesta#452)), Removing emojis - 🍎: Fixing something on macOS. - 🐧: Fixing something on Linux. - 🏁: Fixing something on Windows. - 🤖: Fixing something on Android. - 🍏: Fixing something on iOS. - 🐳: Work about Docker. - 👌: Updating code due to code review changes.
Hello, 😎!
So I noticed there are some discussion around here around if we should or not add more technology specific emojis like shell script#432, storybook#325, or that disscussion on changing the 🐳#287.
I think we should disscus "formally" if we want to keep adding more platform/technology specific emojis, to not only come to a common decission about it, but also be an issue that we can point people when they suggest more of those, maybe event have this on the readme :D
So, should gitmoji be platform agnostic?
The text was updated successfully, but these errors were encountered: