Detach Icondata, making the library more stable; #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes about experience:
- Generics are somewhat janky with the view! macro
- Could not have a signal that can return icons from different libraries directly
(e.g., one SiIcon, one BsIcon). They would have to be wrapped in Icon(..)
- Have to test for binary size
cleanup
carloskiki
force-pushed
the
detach-icondata
branch
from
ebe840a
to
e61dc59
Compare
add icondata as dev-dependency doc-test target wasm;
carloskiki
force-pushed
the
detach-icondata
branch
from
7ce7c18
to
b5fa55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue of making
leptos_iconsfollowicondataupgrade. Icon sources can introduce breaking changes very frequently, which makesleptos_iconsperpetually unstable.This PR resolves this issue by making users (instead of
leptos_icons) depend on an icon source.